Skip to content

Commit

Permalink
Update MIN_TARGET_API and RECOMMENDED_TARGET_API (#2683)
Browse files Browse the repository at this point in the history
  • Loading branch information
misl6 authored Oct 10, 2022
1 parent 5b9b382 commit 1132274
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
6 changes: 3 additions & 3 deletions pythonforandroid/recommendations.py
Original file line number Diff line number Diff line change
Expand Up @@ -135,15 +135,15 @@ def read_ndk_version(ndk_dir):
return ndk_version


MIN_TARGET_API = 26
MIN_TARGET_API = 30

# highest version tested to work fine with SDL2
# should be a good default for other bootstraps too
RECOMMENDED_TARGET_API = 27
RECOMMENDED_TARGET_API = 33

ARMEABI_MAX_TARGET_API = 21
OLD_API_MESSAGE = (
'Target APIs lower than 26 are no longer supported on Google Play, '
'Target APIs lower than 30 are no longer supported on Google Play, '
'and are not recommended. Note that the Target API can be higher than '
'your device Android version, and should usually be as high as possible.')

Expand Down
2 changes: 1 addition & 1 deletion tests/test_recommendations.py
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ def test_check_target_api_warning_target_api(self):
self.assertEqual(
cm.output,
[
"WARNING:p4a:[WARNING]: Target API 25 < 26",
"WARNING:p4a:[WARNING]: Target API 29 < 30",
"WARNING:p4a:[WARNING]: {old_api_msg}".format(
old_api_msg=OLD_API_MESSAGE
),
Expand Down
2 changes: 1 addition & 1 deletion tests/test_toolchain.py
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ def test_create(self):
'pythonforandroid.bootstraps.service_only.'
'ServiceOnlyBootstrap.assemble_distribution'
) as m_run_distribute:
m_get_available_apis.return_value = [27]
m_get_available_apis.return_value = [33]
tchain = ToolchainCL()
assert tchain.ctx.activity_class_name == 'abc.myapp.android.CustomPythonActivity'
assert tchain.ctx.service_class_name == 'xyz.myapp.android.CustomPythonService'
Expand Down

0 comments on commit 1132274

Please sign in to comment.