Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[publish sdl2 win] Update sdl2 and sdl_image versions and add Python 3.12 to supported matrix #95

Merged
merged 4 commits into from
Dec 6, 2023

Conversation

misl6
Copy link
Member

@misl6 misl6 commented Nov 26, 2023

  • We were waiting for an update on SDL_image, in order to avoid multiple releases in a short time, but since there's no update, better to move ahead.
  • Bump sdl2 from 2.26.4 to 2.28.5, bump sdl_image from 2.6.3 to 2.8.0 (and therefore our internal version moved from 0.6.0 to 0.7.0
  • Added Python 3.12 to supported matrix for sdl2 deps.
  • Updated Github Actions
  • Fixes Neither Image nor AsyncImage load webp images.  kivy#8200

@misl6 misl6 changed the title Update sdl2 version and add Python 3.12 to supported matrix [WIP] Update sdl2 version and add Python 3.12 to supported matrix Nov 26, 2023
@misl6
Copy link
Member Author

misl6 commented Nov 26, 2023

First CI run reports (for almost all the jobs):

test_benchmark.py ...................................................... [ 10%]
................                                                         [ 12%]
test_clipboard.py .....                                                  [ 12%]
Windows fatal exception: code 0xc0000374

Current thread 0x00000c5c (most recent call first):
  File "C:\hostedtoolcache\windows\Python\3.10.11\x64\lib\os.py", line 691 in __delitem__
  File "C:\hostedtoolcache\windows\Python\3.10.11\x64\lib\_collections_abc.py", line 968 in pop
  File "C:\hostedtoolcache\windows\Python\3.10.11\x64\lib\site-packages\_pytest\runner.py", line 200 in _update_current_test_var
  File "C:\hostedtoolcache\windows\Python\3.10.11\x64\lib\site-packages\_pytest\runner.py", line 183 in pytest_runtest_teardown
  File "C:\hostedtoolcache\windows\Python\3.10.11\x64\lib\site-packages\pluggy\_callers.py", line 77 in _multicall
  File "C:\hostedtoolcache\windows\Python\3.10.11\x64\lib\site-packages\pluggy\_manager.py", line 115 in _hookexec
  File "C:\hostedtoolcache\windows\Python\3.10.11\x64\lib\site-packages\pluggy\_hooks.py", line 493 in __call__
  File "C:\hostedtoolcache\windows\Python\3.10.11\x64\lib\site-packages\_pytest\runner.py", line 262 in <lambda>
  File "C:\hostedtoolcache\windows\Python\3.10.11\x64\lib\site-packages\_pytest\runner.py", line 341 in from_call
  File "C:\hostedtoolcache\windows\Python\3.10.11\x64\lib\site-packages\_pytest\runner.py", line 261 in call_runtest_hook
  File "C:\hostedtoolcache\windows\Python\3.10.11\x64\lib\site-packages\_pytest\runner.py", line 222 in call_and_report
  File "C:\hostedtoolcache\windows\Python\3.10.11\x64\lib\site-packages\_pytest\runner.py", line 134 in runtestprotocol
  File "C:\hostedtoolcache\windows\Python\3.10.11\x64\lib\site-packages\_pytest\runner.py", line 114 in pytest_runtest_protocol
  File "C:\hostedtoolcache\windows\Python\3.10.11\x64\lib\site-packages\pluggy\_callers.py", line 77 in _multicall
  File "C:\hostedtoolcache\windows\Python\3.10.11\x64\lib\site-packages\pluggy\_manager.py", line 115 in _hookexec
  File "C:\hostedtoolcache\windows\Python\3.10.11\x64\lib\site-packages\pluggy\_hooks.py", line 493 in __call__
  File "C:\hostedtoolcache\windows\Python\3.10.11\x64\lib\site-packages\_pytest\main.py", line 350 in pytest_runtestloop
  File "C:\hostedtoolcache\windows\Python\3.10.11\x64\lib\site-packages\pluggy\_callers.py", line 77 in _multicall
  File "C:\hostedtoolcache\windows\Python\3.10.11\x64\lib\site-packages\pluggy\_manager.py", line 115 in _hookexec
  File "C:\hostedtoolcache\windows\Python\3.10.11\x64\lib\site-packages\pluggy\_hooks.py", line 493 in __call__
  File "C:\hostedtoolcache\windows\Python\3.10.11\x64\lib\site-packages\_pytest\main.py", line 325 in _main
  File "C:\hostedtoolcache\windows\Python\3.10.11\x64\lib\site-packages\_pytest\main.py", line 271 in wrap_session
  File "C:\hostedtoolcache\windows\Python\3.10.11\x64\lib\site-packages\_pytest\main.py", line 318 in pytest_cmdline_main
  File "C:\hostedtoolcache\windows\Python\3.10.11\x64\lib\site-packages\pluggy\_callers.py", line 77 in _multicall
  File "C:\hostedtoolcache\windows\Python\3.10.11\x64\lib\site-packages\pluggy\_manager.py", line 115 in _hookexec
  File "C:\hostedtoolcache\windows\Python\3.10.11\x64\lib\site-packages\pluggy\_hooks.py", line 493 in __call__
  File "C:\hostedtoolcache\windows\Python\3.10.11\x64\lib\site-packages\_pytest\config\__init__.py", line 169 in main
  File "C:\hostedtoolcache\windows\Python\3.10.11\x64\lib\site-packages\_pytest\config\__init__.py", line 192 in console_main
  File "C:\hostedtoolcache\windows\Python\3.10.11\x64\lib\site-packages\pytest\__main__.py", line 5 in <module>
  File "C:\hostedtoolcache\windows\Python\3.10.11\x64\lib\runpy.py", line 86 in _run_code
  File "C:\hostedtoolcache\windows\Python\3.10.11\x64\lib\runpy.py", line 196 in _run_module_as_main
test_clock.py .................
Error: Process completed with exit code 1.

... will try to lower the SDL2 version to see if still happens.

@misl6
Copy link
Member Author

misl6 commented Nov 26, 2023

Update

  • The same issue found via CI can be replicated locally with both newly produced and old artifacts (the ones available on PyPi).

@misl6 misl6 changed the title [WIP] Update sdl2 version and add Python 3.12 to supported matrix [WIP] Update sdl2 and sdl_image versions and add Python 3.12 to supported matrix Dec 5, 2023
@misl6 misl6 changed the title [WIP] Update sdl2 and sdl_image versions and add Python 3.12 to supported matrix Update sdl2 and sdl_image versions and add Python 3.12 to supported matrix Dec 6, 2023
@misl6 misl6 changed the title Update sdl2 and sdl_image versions and add Python 3.12 to supported matrix [publish sdl2 win] Update sdl2 and sdl_image versions and add Python 3.12 to supported matrix Dec 6, 2023
@misl6 misl6 merged commit bfc1a07 into master Dec 6, 2023
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Neither Image nor AsyncImage load webp images.
1 participant