Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMPROVEMENT] Improvements 3d viewer implementation #1283

Merged
merged 49 commits into from
Jul 29, 2024
Merged

[IMPROVEMENT] Improvements 3d viewer implementation #1283

merged 49 commits into from
Jul 29, 2024

Conversation

markusweigelt
Copy link
Contributor

@markusweigelt markusweigelt commented Jul 22, 2024 •
edited
Loading

  • Standardisation of the naming
  • Extension of the global document type detection to render the embedded3dviewer plugin only if document contains model (only applies to KitodoPageView in TypoScript)
  • Adjustment of the documentation
  • Content component/plugin Content component for 3D viewer (optional) slub/dlf-3d-viewers#39 of embedded 3d viewer

Plugin selection
image

Plugin configuration
image

Rendering of plugin
image

markusweigelt and others added 30 commits May 31, 2024 17:27
@markusweigelt
Initial commit of embedded 3d viewer implementation
cb04a34
@markusweigelt
Merge branch 'kitodo:master' into 3d-viewer-integration
18fe909
@markusweigelt
Fix unnecessary change
2ec8fee
@markusweigelt
Fix loading of METS/MODS
cc6188e
@markusweigelt
Improve embedded 3d viewer
151ae7d
@markusweigelt
Remove unused files and add logging to embedded 3d viewer
7df1935
@markusweigelt
Add error handling
22c1f1b
@markusweigelt
Merge branch 'kitodo:master' into 3d-viewer-integration
beeacbd
@markusweigelt
Adjust documentation and improve implemenation
d2754fe
@markusweigelt
Minor changes
34047a3
@markusweigelt
Add extension viewer configuration and select viewer by model format
2a58f0b
@markusweigelt
Update documentation
851772f
@markusweigelt
Remove converted model cause currently no example exist
51a67e9
@markusweigelt
Controller improvements and error handling of embedded 3d viewer
c265eb3
@markusweigelt
Update documentation
2612969
@markusweigelt
Improve documentation
e6fb3f9
@markusweigelt
Codacy fixes
1ed92fc
@markusweigelt
Codacy fixes
56b2155
@markusweigelt
Merge branch 'master' into 3d-viewer-integration
3d3dcaf
@markusweigelt
Update Embedded3DViewer.php
76779d9 
improve types
@markusweigelt
Merge branch 'kitodo:master' into 3d-viewer-integration
15fe6bf
@markusweigelt
Add model-viewer as default viewer
7f16533
@markusweigelt
Merge branch 'kitodo:master' into 3d-viewer-integration
37a0186
@markusweigelt
Mode default viewer implementation to separate method and fix phpstan…
0ccdd99 
… erro
@markusweigelt
Fixes of Codacy errors
8c6b662
@markusweigelt
Fix Codacy issues and improve wording of Html title
bc31f94
@markusweigelt
Adjust parameter type in comment
63b149a
@markusweigelt
Adjust parameter type in comment
b45d8c6
@markusweigelt
Improve wording in extension config documentation
ceae089
@markusweigelt
Update documentation
6cdd9ed
@markusweigelt markusweigelt marked this pull request as ready for review July 22, 2024 10:16
@markusweigelt markusweigelt changed the title Improvements 3d viewer implementation [IMPROVEMENT] Improvements 3d viewer implementation Jul 22, 2024
@markusweigelt markusweigelt mentioned this pull request Jul 23, 2024
Closed
1 task
@sebastian-meyer sebastian-meyer self-requested a review July 23, 2024 12:38
@sebastian-meyer sebastian-meyer added the ⚙ feature A new feature or enhancement. label Jul 23, 2024
@sebastian-meyer sebastian-meyer merged commit 244c2ca into kitodo:master Jul 29, 2024
7 checks passed
@markusweigelt markusweigelt mentioned this pull request Jul 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastian-meyer sebastian-meyer sebastian-meyer approved these changes

Assignees

@markusweigelt markusweigelt

Labels
⚙ feature A new feature or enhancement.
Projects
None yet
Milestone
Kitodo.Presentation 5.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@markusweigelt @sebastian-meyer