Merge pull request #230 from kitloong/feature/update

Update

src/Database/Models/PgSQL/PgSQLColumn.php

@@ -164,7 +164,7 @@ private function setRealSpatialColumn(string $fullDefinitionType): void
             return;
         }
 
-        if (!preg_match('/(\w+)(?:\((\w+)(?:,\s*(\w+))?\))?/', $dataType, $matches)) {
+        if (!preg_match('/(\w+)(?:\((\w+)(?:,\s*(\w+))?\))?/', $dataType, $matches) || !isset($matches[2])) {
             return;
         }
 

src/Migration/Generator/ForeignKeyGenerator.php

@@ -58,10 +58,6 @@ public function makeMethod(ForeignKey $foreignKey): Method
             return new Method(Foreign::FOREIGN, $foreignKey->getLocalColumns());
         }
 
-        if ($foreignKey->getName() === null) {
-            return new Method(Foreign::FOREIGN, $foreignKey->getLocalColumns());
-        }
-
         return new Method(Foreign::FOREIGN, $foreignKey->getLocalColumns(), $foreignKey->getName());
     }
 

tests/Unit/Migration/Generator/ForeignKeyGeneratorTest.php

@@ -0,0 +1,33 @@
+<?php
+
+namespace KitLoong\MigrationsGenerator\Tests\Unit\Migration\Generator;
+
+use KitLoong\MigrationsGenerator\Database\Models\SQLite\SQLiteForeignKey;
+use KitLoong\MigrationsGenerator\Enum\Migrations\Method\Foreign;
+use KitLoong\MigrationsGenerator\Migration\Generator\ForeignKeyGenerator;
+use KitLoong\MigrationsGenerator\Setting;
+use KitLoong\MigrationsGenerator\Tests\TestCase;
+
+class ForeignKeyGeneratorTest extends TestCase
+{
+    public function testGenerateDropWithNullName(): void
+    {
+        $setting = app(Setting::class);
+        $setting->setIgnoreForeignKeyNames(false);
+
+        $foreignKeyGenerator = app(ForeignKeyGenerator::class);
+
+        $method = $foreignKeyGenerator->generateDrop(new SQLiteForeignKey('table', [
+            'name'            => null,
+            'columns'         => ['column'],
+            'foreign_schema'  => null,
+            'foreign_table'   => 'foreign_table',
+            'foreign_columns' => ['foreign_column'],
+            'on_update'       => 'on_update',
+            'on_delete'       => 'on_delete',
+        ]));
+
+        $this->assertSame($method->getName(), Foreign::DROP_FOREIGN);
+        $this->assertEmpty($method->getValues());
+    }
+}