-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for visual regression tests #384
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reekitconcept
force-pushed
the
ree-visual-acceptance-tests
branch
3 times, most recently
from
May 15, 2024 09:55
0d74ef6
to
384cfe8
Compare
- add cypress plugin dependency - add cypress configuration files for visual targets - configure Makefile - configure github plugin for CI - customize and fix image snapshot generation - customize snapshots folder location - fix scrollability of css for full-page screenshots - fix lazy image loading - disable hover effect on images - disable hyphenation (currently disabled but code is available) - limit browser to firefox only - test utilities - generate series of tests for different resolutions - generate series of tests visiting a list of urls - cumulative testing - add base.js test that * tests two pages in anonymous view and serves as an example * test a list of pages as an example * same in authenticated mode
reekitconcept
force-pushed
the
ree-visual-acceptance-tests
branch
from
May 15, 2024 13:35
b3fa93f
to
a45a612
Compare
reekitconcept
changed the title
WIP Add support for visual regression tests
Add support for visual regression tests
May 15, 2024
@reekitconcept Looks awesome! LGTM, however, I'm missing some docs, afterwards, let's merge it right away.
@tisto We need to talk to you about how to deal with that last ones. |
* main: (25 commits) Upgrade to a39, enable new image widget (#405) Finish interrupted push Fixes #400, install in Volto 17 Fix Invalid html structure in caption component (#401) build deps Upgrade to Volto a37 (#403) Release 4.0.0 Fix release-it script Changelog Fix tabbing in header (reapplies #346 as breaking) (#374) Customizable mobile navigation (#393) Fix Description block width in Edit/Add (#394) Slight improvements Adjust height Add BMv3 ready logo Remove not needed dockerfiles folder Update setup. Use new images. (#390) fix Logo alt-Title + add German translations (#337) fix link in introduction block being smaller than normal text (#366) Release 3.3.2 ...
* main: Update to V18a46 (#419) Fix deploy Get rid of all barrel imports, ESlint rule to enforce it. (#418) Release 5.0.1 Changelog Changelog Added lint rule Updates from Oct24 (#417) Update versions to latest volto-highlight-block, volto-button-block (#408) Fix eslint config (#407) Release 5.0.0 Better changelog
sneridagh
added a commit
that referenced
this pull request
Oct 21, 2024
* main: Add support for visual regression tests (#384)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add cypress plugin dependency
add cypress configuration files for visual targets
configure Makefile
configure github plugin for CI
customize and fix image snapshot generation
test utilities
add base.js test that