Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get parameterized list of datapoints #46
base: master
Are you sure you want to change the base?
Get parameterized list of datapoints #46
Changes from 2 commits
d2c78a0
b88e7d8
61ce049
1513f04
3133ab2
461d840
f68d732
a33e391
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think about trying to make these calls a little more dynamic? Is there a way we could use
__callStatic
for these since they're almost identical code? Do you think that would be a good idea here or should we avoid that for reasons I'm not thinking about?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dvanscott These calls are mostly convenience methods for end users. These are not used anywhere in our code directly.
These are also supposed to act as a template for end users it they want to add more such methods for their own use. That was one of the reason I wanted to keep it more readable.