Dockerfile updates #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sample Docker build arguments to use with the labels: --build-arg BUILD_DATE=$(date -u +'%Y-%m-%dT%H:%M:%SZ') / --build-arg APPLICATION_NAME=recruiter-booter / --build-arg BUILD_VERSION=v0.1
A Requirements.txt file will track versions of python libraries
Comment on lines
-4
to
-5
| ## Proposed Dev Environment | ||
| I added a Dockerfile as a proposed Dev Environment. |
There was a problem hiding this comment.
No Longer Necessary -
| @@ -1,5 +1,14 @@ | |||
| FROM tiangolo/uwsgi-nginx:python3.6-alpine3.7 | |||
There was a problem hiding this comment.
I would like to move away from this Dockerhub image. The plan is to build my own and host it in my dockerhub to ensure that we have more control over the image.
|
haha alright there, I wont really have time till next week for these
thingies, but im off for 2 wks
Jeffrey Eggert Jr.
LinkedIn <https://www.linkedin.com/in/jeffeggertjr/> | [email protected]
Full Stack Senior Automation Engineer
973-727-0722
…On Tue, Nov 12, 2019 at 1:39 PM davidhqu ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In Dockerfile
<#4 (comment)>
:
> @@ -1,5 +1,14 @@
FROM tiangolo/uwsgi-nginx:python3.6-alpine3.7
I would like to move away from this Dockerhub image. The plan is to build
my own and host it in my dockerhub to ensure that we have more control over
the image.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#4?email_source=notifications&email_token=AA2HRG4RZPUUP2HEDZ5QM3DQTLZ5PA5CNFSM4JL5RL4KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCLJAXCQ#pullrequestreview-315755402>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA2HRG4E2DGD6SSTI62NEZDQTLZ5PANCNFSM4JL5RL4A>
.
|
|
Cool cool, I will continue to make changes and no rush to get to these. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a requirements.txt file to add all required python libraries.
Updated Dockerfile and Readme to include additional labels.