Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken build of performWithRetry #14

Closed

Conversation

dahlia
Copy link

@dahlia dahlia commented Jul 26, 2017

Fixes #13.

It was broken due to retry-0.7's changing of retrying function.

It was broken due to retry-0.7's changing of retrying function.

See also: Soostone/retry@a2ef0f0
@dahlia
Copy link
Author

dahlia commented Jul 26, 2017

A job on GHCVER=7.6.3 is broken, but it seems it has been so.

@atodorov
Copy link

+1 I also need this.

@guillaume-nargeot can we get this merged and a new package version published ?

@dahlia
Copy link
Author

dahlia commented Jan 15, 2018

@guillaume-nargeot Could you review this?

@NickSeagull
Copy link

So this is not maintained anymore?

@creichert
Copy link

You can likely drop support for 7.6 at this point and add support for GHC 8's.

If you want, you can use this drop-in circleci config: https://gist.github.com/creichert/efb84716d628c431e827ff95289b6aa7

It will test lts-9 to lts-12 and has a nightly resolver test too. All you would need to do is change the "package.yaml" to your cabal file if not using hspec.

I'd be happy to submit a PR. I think it's important to get this project up-to-date because it's practically the only viable option for coverage in Haskell.

Additionally, we should enable reports for this repo and upload them. Do you want PRs?

@iustin
Copy link

iustin commented Nov 24, 2019

Friendly ping. I'd like to use this as well, but is still broken. Guillaume, do you intend to update this?

@DamienCassou
Copy link

Same for me.

@dahlia
Copy link
Author

dahlia commented Mar 22, 2022

I give up this old pull request. 👋🏼 To whom long-waited this to be merged: use the hpc-codecov package instead, which is actively maintained.

@dahlia dahlia closed this Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to install codecov-haskell
6 participants