Read the color pairs in top to bottom order, instead of prior complicated manner #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bolding parentheses makes it easier to see and distinguish between the rainbow colors.
Add option to bold parentheses, defaulting to on
Hopefully they still make sense on more powerful terminals as well (they *should*) but the old order had several in a row which degenerated into just "red".
complicated manner This makes it so both g:rbt_colorpairs in the user .vimrc and s:pairs in the autoload are easier to understand, with the highest level scope being the first entry, and so on The behavior this replaces is to roll back from the end of the list, with odd truncation stuff happening with the max trimming, making it completely unpredictable what color will be where for certain size lists This patch makes it so the first item in the list (['brown', 'RoyalBlue3'] in pairs) is the top level scope in the file, and so on.
|
This repo is, AFAICT, unmaintained. I am maintaining a fork at https://github.com/eapache/rainbow_parentheses.vim - if you resubmit the PR there I would be happy to take a look at it. |
Conflicts: autoload/rainbow_parentheses.vim
|
Happy to accept if you resubmit to my repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it so both g:rbt_colorpairs in the user .vimrc and s:pairs in
the autoload are easier to understand, with the highest level scope
being the first entry, the 2nd level scope being the second entry, etc.
The behavior this replaces is complicated and probably unintended, being a mix of truncation from max, extension from max, and using the list backwards. Note, I did not effect the s:max code, just the color order.