-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RHPAM-4700: Upgrade Jackson to 2.15.2 to make it work with SnakeYAML … #871
Conversation
jenkins retest this please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm still convinced we should have been fine anyway with this quarkusio/quarkus#30440 but I'm fine with this solution
@lucamolteni I don't think so because |
You're correct, it uses snakeyaml 1.33. We don't need to use snakeyaml 2.0.0 necessarily, as long as we don't use that specific no args constructor |
Yes, that is true but our ultimate goal is not only to prevent the vulnerability (which is technically not present in this project) but also to escape the reporting tools, which mark the project as vulnerable just because it depends on SnakeYAML 1.33. |
Jenkins retest this. I want to check if kiegroup/optaplanner#33 actually disables Sonar analysis. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
…2.0 (#870)
https://issues.redhat.com/browse/RHPAM-4700
No org.yaml:snakeyaml:jar:1.33.0 traces on optaweb* or kogito-examples projects after related PRs
Related PRs: