forked from apache/incubator-kie-kogito-serverless-operator
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[9.100.x-prod] SRVLOGIC-299 SRVLOGIC-266 SRVLOGIC-185 - Update Go Image 1.21; Bundles Update; Manager Config set #46
Merged
rgdoliveira
merged 3 commits into
kiegroup:9.100.x-prod
from
ricardozanini:srvlogic-299
May 23, 2024
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 changes: 8 additions & 10 deletions
18
bundle.prod/manifests/logic-operator-rhel8-builder-config_v1_configmap.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
46 changes: 46 additions & 0 deletions
46
bundle.prod/manifests/logic-operator-rhel8-controllers-config_v1_configmap.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,46 @@ | ||
apiVersion: v1 | ||
data: | ||
controllers_cfg.yaml: | | ||
# The default size of Kaniko PVC when using the internal operator builder manager | ||
defaultPvcKanikoSize: 1Gi | ||
# How much time (in seconds) to wait for a devmode workflow to start. | ||
# This information is used for the controller manager to create new devmode containers and setup the healthcheck probes. | ||
healthFailureThresholdDevMode: 50 | ||
# Default image used internally by the Operator Managed Kaniko builder to create the warmup pods | ||
kanikoDefaultWarmerImageTag: gcr.io/kaniko-project/warmer:v1.9.0 | ||
# Default image used internally by the Operator Managed Kaniko builder to create the executor pods | ||
kanikoExecutorImageTag: gcr.io/kaniko-project/executor:v1.9.0 | ||
# The Jobs Service image to use, if empty the operator will use the default Apache Community one based on the current operator's version | ||
jobsServicePostgreSQLImageTag: "registry.redhat.io/openshift-serverless-1/logic-jobs-service-postgresql-rhel8:1.33.0" | ||
jobsServiceEphemeralImageTag: "registry.redhat.io/openshift-serverless-1/logic-jobs-service-ephemeral-rhel8:1.33.0" | ||
# The Data Index image to use, if empty the operator will use the default Apache Community one based on the current operator's version | ||
dataIndexPostgreSQLImageTag: "registry.redhat.io/openshift-serverless-1/logic-data-index-postgresql-rhel8:1.33.0" | ||
dataIndexEphemeralTag: "registry.redhat.io/openshift-serverless-1/logic-data-index-ephemeral-rhel8:1.33.0" | ||
# SonataFlow base builder image used in the internal Dockerfile to build workflow applications in preview profile | ||
# Order of precedence is: | ||
# 1. SonataFlowPlatform in the given namespace | ||
# 2. This configuration | ||
# 3. The FROM in the Dockerfile in the operator's namespace "sonataflow-operator-builder-config" configMap. | ||
# If 1 or 2, the FROM tag will be replaced by the tag se there. | ||
# If empty the operator will use the default Apache Community one based on the current operator's version. | ||
sonataFlowBaseBuilderImageTag: "registry.redhat.io/openshift-serverless-1/logic-swf-builder-rhel8:1.33.0" | ||
# The image to use to deploy SonataFlow workflow images in devmode profile. | ||
# If empty the operator will use the default Apache Community one based on the current operator's version. | ||
sonataFlowDevModeImageTag: "registry.redhat.io/openshift-serverless-1/logic-swf-devmode-rhel8:1.33.0" | ||
# The default name of the builder configMap in the operator's namespace | ||
builderConfigMapName: "logic-operator-rhel8-builder-config" | ||
# Quarkus extensions required for workflows persistence. These extensions are used by the SonataFlow build system, | ||
# in cases where the workflow being built has configured postgresql persistence. | ||
postgreSQLPersistenceExtensions: | ||
- groupId: com.redhat.quarkus.platform | ||
artifactId: quarkus-jdbc-postgresql | ||
version: 3.8.4.redhat-00002 | ||
- groupId: com.redhat.quarkus.platform | ||
artifactId: quarkus-agroal | ||
version: 3.8.4.redhat-00002 | ||
- groupId: org.kie | ||
artifactId: kie-addons-quarkus-persistence-jdbc | ||
version: 9.100.0.redhat-00004 | ||
kind: ConfigMap | ||
metadata: | ||
name: logic-operator-rhel8-controllers-config |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ricardozanini Just a reminder to double-check. In 9.99.x-pod (i.e., previous release), it looks like we used
registry.access.redhat.com/ubi9/openjdk-17:latest instead.
see:
kogito-serverless-operator/bundle.osl/manifests/logic-operator-rhel8-builder-config_v1_configmap.yaml
Line 11 in 5325a42
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
talking to my self.... after seen the image names provided by @rgdoliveira .
If produtized DI and JS images are on rhel8....
registry.redhat.io/openshift-serverless-1/logic-jobs-service-postgresql-rhel8:1.33.0
maybe ubi8 is the correct choice here.
Anyway, just forget my comment if don't make sense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was ubi9, but yeah I'm downgrading to align and avoid problems.