Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-v7.13.x-blue-next][RHPAM-4904] Add required annotations for Infrastructure Feature Test #954

Conversation

akumar074
Copy link
Member

@akumar074 akumar074 commented Mar 19, 2024

Copy link
Member

@mareknovotny mareknovotny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@mareknovotny
Copy link
Member

there are just format errors, please check what @rgdoliveira did to fix them at a48a0d1

@rgdoliveira
Copy link
Member

@akumar074 I guess the easier way for you to fix the failure in ci/prow/format is running ./hack/go-fmt.sh script inside the operator repo. I run it and it showed a diff on file pkg/apis/app/v2/zz_generated.deepcopy.go, I believe you have to commit that diff too.

It seems as part of previous PR Bump BAMOE version in the next branch this file was modified and maybe also the ci/prow/format failed before.

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.1% Duplication on New Code

See analysis details on SonarCloud

@mareknovotny
Copy link
Member

/retest-required

Copy link
Contributor

openshift-ci bot commented Mar 26, 2024

@akumar074: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/unit 773a386 link true /test unit

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Contributor

openshift-ci bot commented Mar 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akumar074, mareknovotny, rgdoliveira

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [akumar074,mareknovotny,rgdoliveira]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@akumar074
Copy link
Member Author

Hello @jakubschwan, Kindly provide your review on this PR and merge if it looks good.

@mareknovotny
Copy link
Member

/lgtm

@rgdoliveira
Copy link
Member

@mareknovotny @akumar074 Just one thing, I believe ci/prow/unit should not fail, at least it was not before #943 was merged.

I would guess something may be missing to be updated? Sorry I'm no expert in this repo but if you need help I can try to investigate.

@rgdoliveira
Copy link
Member

we discussed on channel what might be the reason of ci/prow/unit failing. So let's merge this one as it is and create a new PR trying to fix the test failure.

@akumar074 akumar074 merged commit dfd534b into kiegroup:release-v7.13.x-blue-next Mar 28, 2024
7 of 9 checks passed
akumar074 added a commit that referenced this pull request Apr 12, 2024
)

* [KIECLOUD-732] add missing subscription for BAMOE 8.0.4-1 operator

* Update OWNERS

* Update BAMOE bundle for CVE respin

* Update BAMOE bundle for CVE respin (Multiple OpenJDK CVEs)

* Bump BAMOE version in the next branch

* add Abhishek and Rishiraj to OWNERS file

* [release-v7.13.x-blue-next] [RHPAM-4894] upgrade OCP minimal version to 4.12 (#950)

* [release-v7.13.x-blue-next][RHPAM-4904] Add required annotations for Infrastructure Feature Test (#954)

* [release-v7.13.x-blue-next][RHPAM-4904] Add required annotations for Infrastructure Feature Test

* Fixed text formatting

* Fix formatting

* Removed *.0.3 from rhpam-config

* Fixed upgrade_test.go

* Fixed current version and prior version

* Fixed replaces by on 8.0.5-1 operator

---------

Co-authored-by: Roberto Oliveira <[email protected]>
Co-authored-by: Marek Novotný <[email protected]>
Co-authored-by: openshift-ci[bot] <75433959+openshift-ci[bot]@users.noreply.github.com>
akumar074 added a commit to akumar074/kie-cloud-operator that referenced this pull request Aug 15, 2024
…Infrastructure Feature Test (kiegroup#954)

* [release-v7.13.x-blue-next][RHPAM-4904] Add required annotations for Infrastructure Feature Test

* Fixed text formatting

* Fix formatting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants