Allow multiple implementations of KieServerController through the ServiceLoader #3069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the implementation of KieServerController getController() in KieServerImpl uses the default, or the first class loaded through the ServiceLoader. This makes it difficult to override, especially as the WebSocket implementation is usually present.
This change allows multiple implementations to exist, and when they do, they are checked to see if they are supported, and are of a higher priority. The default is not instantiated automatically as this is always available to the ServiceLoader.
This change is designed to mirror the KieServicesClientProvider. However, the change could not be applied to the KieServerController interface as that is also used elsewhere in the kie-server (for example org.kie.server.controller.websocket.WebSocketKieServerControllerImpl)