-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Improve error message on mockStep failure #74
Conversation
@shubhbapna I think my last commit solves it, can you please trigger again? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry just a nitpick but is it possible to fix the linter warning message?
I don't know how, it must be named mockWith otherwise the destructuring doesn't work. Can we supress for that one line? Also: consider making the lint fail on warnings ;) |
You could rename the destructuring:
Or adding this line of comment directly above it should also disable it:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much!
This helps to find which mock rule is not working. If there are multiple
mockSteps
, it's hard to figure out otherwise which one is wrong. This helps clarify it.Before:
After: