-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add multiple images per page #1
base: development
Are you sure you want to change the base?
Conversation
I copy-pasted the file too quickly...
Now the graphs are always displayed on every page, with a specific one chosen by default.
I added 3 commits to fix issues on my new code. Edit : the branch develop-alternate-tabs has been merged into the branch development, adding the commits to this pull request. See the updated description. |
With the previous version, the graphs were always shown, even for special pages as the pledges page, etc. Updating pages handling the internaut's cash is clearly not a good idea.
The image source was http://kicktraq.com/... which always triggers a 301 Moved Permanently to http://www.kicktraq.com/... This redirect is now avoided.
These commits add the possibility to display several graphs on a page. If more than one, a tab bar appears to choose the graph.
I also split the code into methods of an object (the code grew too big) and added unit tests.
edit :
as discussed via emails, here is a list of additional features I added :