Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add multiple images per page #1

Open
wants to merge 13 commits into
base: development
Choose a base branch
from

Conversation

dduponchel
Copy link

These commits add the possibility to display several graphs on a page. If more than one, a tab bar appears to choose the graph.
I also split the code into methods of an object (the code grew too big) and added unit tests.

edit :
as discussed via emails, here is a list of additional features I added :

  • all the tabs are shown, only the default tab changes between the pages
  • the hidden images are lazy-loaded
  • a new "more info" tab which redirect to the kicktraq page

@dduponchel
Copy link
Author

I added 3 commits to fix issues on my new code.
On my branch develop-alternate-tabs I also added an extra commit which changes the behavior of the plugin. Instead of displaying 1 image on the project home and 2 images (+ tabs) on the backers page like in the current pull request, we always display the tabs with all the available graphs, the current page only changes the default tab.
If you prefer this behavior, I will add the commit to the pull request.

Edit : the branch develop-alternate-tabs has been merged into the branch development, adding the commits to this pull request. See the updated description.

With the previous version, the graphs were always shown, even for
special pages as the pledges page, etc. Updating pages handling the
internaut's cash is clearly not a good idea.
The image source was http://kicktraq.com/... which always triggers a
301 Moved Permanently to http://www.kicktraq.com/...
This redirect is now avoided.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant