MBL-1213: Stop sending token as query param for V1, send the token as…

… basic auth header (#1958)

app/src/main/java/com/kickstarter/libs/CurrentUser.java

@@ -49,11 +49,19 @@ public String getAccessToken() {
   }
 
   @Override
-  public void login(final @NonNull User newUser, final @NonNull String accessToken) {
+  public void login(final @NonNull User newUser) {
     Timber.d("Login user %s", newUser.name());
+    this.user.onNext(newUser);
+  }
 
+  @Override
+  public void setToken(final @NonNull String accessToken) {
+    // - Clean previous token in case there is any
+    this.accessTokenPreference.delete();
+    this.deviceRegistrar.unregisterDevice();
+
+    // - Register new token
     this.accessTokenPreference.set(accessToken);
-    this.user.onNext(newUser);
     this.deviceRegistrar.registerDevice();
   }
 

app/src/main/java/com/kickstarter/libs/CurrentUserType.java

@@ -9,11 +9,19 @@
 
 public abstract class CurrentUserType {
 
+  /***
+   * Persist a new token,
+   * - retrieved form #exchange endpoint {/v1/oauth/authorizations/exchange}
+   * - retrieved from Facebook login
+   * - retrieved from endpoint {/xauth/access_token} soon to be deprecated
+   */
+  public abstract void setToken(final @NonNull String accessToken);
+
   /**
    * Call when a user has logged in. The implementation of `CurrentUserType` is responsible
-   * for persisting the user and access token.
+   * for persisting the user.
    */
-  public abstract void login(final @NonNull User newUser, final @NonNull String accessToken);
+  public abstract void login(final @NonNull User newUser);
 
   /**
    * Call when a user should be logged out.

app/src/main/java/com/kickstarter/libs/CurrentUserV2.kt

@@ -10,11 +10,17 @@ import io.reactivex.subjects.BehaviorSubject
 import timber.log.Timber
 
 abstract class CurrentUserTypeV2 {
+
+    /***
+     * Persist a new token, retrieved form #exchange endpoint {/v1/oauth/authorizations/exchange}
+     */
+    abstract fun setToken(accessToken: String)
+
     /**
      * Call when a user has logged in. The implementation of `CurrentUserType` is responsible
-     * for persisting the user and access token.
+     * for persisting the user.
      */
-    abstract fun login(newUser: User, accessToken: String)
+    abstract fun login(newUser: User)
 
     /**
      * Call when a user should be logged out.
@@ -106,10 +112,18 @@ class CurrentUserV2(
     override val accessToken: String?
         get() = accessTokenPreference.get()
 
-    override fun login(newUser: User, accessToken: String) {
+    override fun login(newUser: User) {
         Timber.d("Login user %s", newUser.name())
-        accessTokenPreference.set(accessToken)
         user.onNext(KsOptional.of(newUser))
+    }
+
+    override fun setToken(accessToken: String) {
+        // - Clean previous token in case there is any
+        accessTokenPreference.delete()
+        deviceRegistrar.unregisterDevice()
+
+        // - Register new token
+        accessTokenPreference.set(accessToken)
         deviceRegistrar.registerDevice()
     }