-
-
Notifications
You must be signed in to change notification settings - Fork 840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the sign in / account creation experiences #1008
Conversation
…n, rather than redirecting user to another screen to sign in
…l sign up - Google sign in is pending with the gsi client code. Will see if I can get that working - Check in relevant image assets
- Disable the gsi client side code since it's being finnicky and inconsistent
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
14541143 | Triggered | Generic Password | 530b44c | .github/workflows/run_evals.yml | View secret |
14810367 | Triggered | Generic High Entropy Secret | 530b44c | documentation/src/components/ChatwootWidget.js | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
- Code automatically becomes invalid after 30 minutes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tried it out. The new login page looks pretty neat! Left some comments but otherwise it seems good to merge
new_signin_demo.mp4