Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the sign in / account creation experiences #1008

Merged
merged 32 commits into from
Dec 17, 2024

Conversation

sabaimran
Copy link
Member

  • Make it easier to quickly create the account without losing track of where you are
  • Show some capabilities before you sign on
new_signin_demo.mp4

Copy link

gitguardian bot commented Dec 12, 2024

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
14541143 Triggered Generic Password 530b44c .github/workflows/run_evals.yml View secret
14810367 Triggered Generic High Entropy Secret 530b44c documentation/src/components/ChatwootWidget.js View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@sabaimran sabaimran marked this pull request as ready for review December 14, 2024 19:06
src/khoj/routers/email.py Outdated Show resolved Hide resolved
src/khoj/database/adapters/__init__.py Outdated Show resolved Hide resolved
src/khoj/database/adapters/__init__.py Outdated Show resolved Hide resolved
@sabaimran sabaimran requested a review from debanjum December 16, 2024 20:31
Copy link
Member

@debanjum debanjum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried it out. The new login page looks pretty neat! Left some comments but otherwise it seems good to merge

src/khoj/routers/email.py Outdated Show resolved Hide resolved
src/interface/web/app/automations/layout.tsx Outdated Show resolved Hide resolved
src/interface/web/app/automations/layout.tsx Outdated Show resolved Hide resolved
src/interface/web/app/agents/layout.tsx Outdated Show resolved Hide resolved
src/interface/web/app/agents/layout.tsx Outdated Show resolved Hide resolved
src/khoj/routers/auth.py Outdated Show resolved Hide resolved
@sabaimran sabaimran merged commit 6f3218f into master Dec 17, 2024
10 checks passed
@sabaimran sabaimran deleted the features/new-sign-in-page branch December 17, 2024 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants