Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miscellaneous improvements for 2025-W02 #218

Merged
merged 22 commits into from
Jan 13, 2025
Merged

Miscellaneous improvements for 2025-W02 #218

merged 22 commits into from
Jan 13, 2025

Conversation

khaeru
Copy link
Owner

@khaeru khaeru commented Jan 9, 2025

PR checklist

  • Checks all ✅
  • Update documentation
  • Update doc/whatsnew.rst

@khaeru khaeru added enh Enhancements & new features data-source Issues related to specific web services/data source(s) labels Jan 9, 2025
@khaeru khaeru self-assigned this Jan 9, 2025
khaeru added a commit that referenced this pull request Jan 9, 2025
khaeru added a commit that referenced this pull request Jan 9, 2025
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.15%. Comparing base (fc68ccf) to head (2fadd96).
Report is 23 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #218      +/-   ##
==========================================
- Coverage   98.84%   98.15%   -0.70%     
==========================================
  Files         101      101              
  Lines        8316     8399      +83     
==========================================
+ Hits         8220     8244      +24     
- Misses         96      155      +59     
Files with missing lines Coverage Δ
sdmx/__init__.py 100.00% <100.00%> (ø)
sdmx/client.py 96.17% <100.00%> (-1.64%) ⬇️
sdmx/format/xml/common.py 100.00% <100.00%> (ø)
sdmx/reader/xml/common.py 100.00% <100.00%> (ø)
sdmx/reader/xml/v21.py 99.19% <100.00%> (-0.13%) ⬇️
sdmx/reader/xml/v30.py 95.19% <100.00%> (ø)
sdmx/source/__init__.py 100.00% <100.00%> (+5.06%) ⬆️
sdmx/testing/__init__.py 99.20% <100.00%> (+0.15%) ⬆️
sdmx/testing/data.py 100.00% <ø> (ø)
sdmx/tests/format/test_format_xml.py 100.00% <100.00%> (ø)
... and 7 more

... and 16 files with indirect coverage changes

khaeru added a commit to khaeru/sdmx-test-data that referenced this pull request Jan 9, 2025
@khaeru khaeru force-pushed the enh/2025-w02 branch 5 times, most recently from fa1bc13 to bd10375 Compare January 10, 2025 17:15
khaeru added a commit to khaeru/sdmx-test-data that referenced this pull request Jan 10, 2025
khaeru added a commit that referenced this pull request Jan 11, 2025
khaeru added a commit that referenced this pull request Jan 11, 2025
@khaeru khaeru force-pushed the enh/2025-w02 branch 2 times, most recently from 3fc40fa to dc7010c Compare January 13, 2025 16:29
khaeru added a commit that referenced this pull request Jan 13, 2025
khaeru added a commit that referenced this pull request Jan 13, 2025
khaeru added a commit that referenced this pull request Jan 13, 2025
khaeru added a commit that referenced this pull request Jan 13, 2025
khaeru added a commit that referenced this pull request Jan 13, 2025
khaeru added a commit that referenced this pull request Jan 13, 2025
khaeru added a commit that referenced this pull request Jan 13, 2025
khaeru added 21 commits January 13, 2025 18:18
- Locate schemas in any subdir of `schema_dir` arg.
- Add max_errors parameter.
- Only call XMLSchema.validate() once.
- Don't hard-code valid root elements; interpret the error log.
- Log all messages.
- Adjust tests.
- Address multiple IMF service in docs (#38).
- Ensure URN.groupdict always exists.
- Handle KeyError in .reader.xml.v30.Reference.
- Test using IMF specimen.
OBS_VALUE resembling "100,00" are returned by the AR1 source, at least.
- Sort alpha.
- Shorten names.
- Type hint all test functions.
@khaeru khaeru merged commit f8560ab into main Jan 13, 2025
20 checks passed
@khaeru khaeru deleted the enh/2025-w02 branch January 13, 2025 17:22
@khaeru khaeru mentioned this pull request Jan 13, 2025
khaeru added a commit that referenced this pull request Jan 14, 2025
khaeru added a commit that referenced this pull request Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data-source Issues related to specific web services/data source(s) enh Enhancements & new features
Projects
None yet
1 participant