Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle validFrom, validTo, and annotations on ItemSchemes #143

Merged
merged 5 commits into from
Oct 10, 2023
Merged

Conversation

khaeru
Copy link
Owner

@khaeru khaeru commented Oct 9, 2023

Closes #142.

PR checklist

  • Checks all ✅
  • Update documentation N/A
  • Update doc/whatsnew.rst

@khaeru khaeru added bug xml SDMX-ML format reader Read file formats defined by the SDMX standards labels Oct 9, 2023
@khaeru khaeru self-assigned this Oct 9, 2023
@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

Merging #143 (4cdd7d2) into main (7363a51) will decrease coverage by 2.41%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #143      +/-   ##
==========================================
- Coverage   98.27%   95.87%   -2.41%     
==========================================
  Files          87       87              
  Lines        6437     6445       +8     
==========================================
- Hits         6326     6179     -147     
- Misses        111      266     +155     
Files Coverage Δ
sdmx/reader/xml/v21.py 97.69% <100.00%> (-0.13%) ⬇️
sdmx/testing/__init__.py 99.28% <ø> (ø)
sdmx/tests/reader/test_reader_xml_v21.py 100.00% <100.00%> (ø)

... and 17 files with indirect coverage changes

@khaeru
Copy link
Owner Author

khaeru commented Oct 9, 2023

@goatsweater can you please let me know if you are able to test this branch? You could install with something like:

pip install --upgrade "sdmx1 @ git+https://github.com/khaeru/sdmx.git@issue/142"

…and then use it against the "internal services" you mentioned in #142.

If that would take a long time or is otherwise not possible, that's fine; I'll just merge and make a patch release with the fix.

@goatsweater
Copy link

I installed the branch and re-ran the services. I am now appropriately seeing annotations and valid to/from dates.

@khaeru khaeru merged commit 7f51bd7 into main Oct 10, 2023
16 checks passed
@khaeru khaeru deleted the issue/142 branch October 11, 2023 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug reader Read file formats defined by the SDMX standards xml SDMX-ML format
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some metadata missing on codelists parsed from SDMX-ML
2 participants