Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update workaround for #145 #154

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Update workaround for #145 #154

merged 1 commit into from
Nov 26, 2024

Conversation

khaeru
Copy link
Owner

@khaeru khaeru commented Nov 26, 2024

The regression is still present in xarray 2024.11.0, so relax the mark condition to apply to versions equal to or greater than 2024.10.0.

PR checklist

  • Checks all ✅
  • Update documentation N/A, test changes only
  • Update doc/whatsnew.rst

Still present in xarray 2024.11.0.
@khaeru khaeru self-assigned this Nov 26, 2024
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.85%. Comparing base (b6d92e1) to head (e7d3254).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #154   +/-   ##
=======================================
  Coverage   99.85%   99.85%           
=======================================
  Files          52       52           
  Lines        4705     4705           
=======================================
  Hits         4698     4698           
  Misses          7        7           
Files with missing lines Coverage Δ
genno/testing/__init__.py 100.00% <ø> (ø)

@khaeru khaeru merged commit b1b7941 into main Nov 26, 2024
20 checks passed
@khaeru khaeru deleted the issue/145-workaround-2 branch November 26, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant