Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily tolerate regression in xarray #146

Merged
merged 2 commits into from
Oct 29, 2024
Merged

Conversation

khaeru
Copy link
Owner

@khaeru khaeru commented Oct 29, 2024

cf. #145

PR checklist

  • Checks all ✅
  • Update documentation N/A, test changes only
  • Update doc/whatsnew.rst

- Add .testing.MARK for reusable marks.
@khaeru khaeru self-assigned this Oct 29, 2024
@khaeru khaeru changed the title Work around regression in xarray Temporarily tolerate regression in xarray Oct 29, 2024
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.80%. Comparing base (18d3ec2) to head (36043d5).
Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##              main     #146      +/-   ##
===========================================
- Coverage   100.00%   99.80%   -0.20%     
===========================================
  Files           51       51              
  Lines         4695     4699       +4     
===========================================
- Hits          4695     4690       -5     
- Misses           0        9       +9     
Files with missing lines Coverage Δ
genno/testing/__init__.py 100.00% <100.00%> (ø)
genno/tests/core/test_quantity.py 100.00% <100.00%> (ø)
genno/tests/test_operator.py 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

@khaeru khaeru merged commit aeeda54 into main Oct 29, 2024
16 of 17 checks passed
@khaeru khaeru deleted the issue/145-workaround branch October 29, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant