-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Miscellaneous improvements for 2023-W43 #105
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #105 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 47 48 +1
Lines 3926 4041 +115
==========================================
+ Hits 3926 4041 +115
|
khaeru
added a commit
that referenced
this pull request
Oct 27, 2023
Adjust references in code and tests.
Adjust usage and references.
- Retain the original name for backwards compatibility. - Adjust usage and references.
Use check_like=True to allow different index order.
Quantity classes now take care of unit handling.
Avoids warnings raised by sparse.
- Update ruff 0.0.287 → 0.1.2. - Replace black with ruff-format --check. - Update mypy 1.4.1 → 1.6.1.
This preserves support for downstream usage like: import genno genno.computations.add(…)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add_mul()
to automatically determine dimensionality of result automatically for:add()
,div()
,sub()
, and any other basic arithimetic operations.+
,-
,/
,*
.Key.__div__
to handlek / ("a", "b")
,k1 / k2
.Key.__mul__
to handlek * ("a", "b")
,k1 * k2
.black
formatting withruff format
.PR checklist