Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request addresses a critical issue where the backend Docker image was failing to build correctly. The root cause was traced back to the recent update involving
directory.build.props
and related files, which were not being included in the Docker image(s).Details
PrivateAsset="All"
flag. This was preventingdotnet pack
from copying necessary files, leading to the build issue../src/database
. This limited its access to files located at the root of./src
during the Docker build. I've adjusted the context to resolve this issue.platform: linux/amd64
to themymeetingsdb
container. This change ensures compatibility with ARM-based MacBooks (M1/M2), aiding in broader development support.Suggested Documentation Update
Given the compatibility enhancement for ARM processors, I recommend we include a link in the README to guide users on configuring Docker to run SQL Server on ARM architectures. This will be particularly helpful for those using newer MacBook models.
Conclusion
These changes should resolve the backend en dbmigrator Docker image build issues and improve our project's compatibility across different development environments. I welcome any further suggestions.
In order to prevent breaking the docker images I created this issue #298