-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/#19 dictionaries tops #45
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stats-overview example for a brand new player.
…ration. Generated to generated sources for now. - We may need to generate in the mail sources to be able to use them in the other module. Or to include generated source in the build jar.
…ertJ generators for the generated classes. - Started replacing PlayerIndexData with a generated class. - PlayerIndexData marked deprecated. - One test from JacksonUtilsTest changed from PlayerIndexData to GetIndexDataResponse with AssertJ generators. - Ok and error code constants extracted to ApiErrors. Usage in one place only.
…h generated GetIndexDataResponse.
…rSrv. ! kgParserSpringBoot will fail now. Let's test Github Actions.
…eted. All tests should now work.
…el). In JacksonUtils, PlayerSummary replaced with GetSummaryResponse. - OpenAPI generator generates empty objects for "oneOf" and NOT "type: object", therefore tuning field made just Object, which can be cast to Map or List depending on present or non-present tuning. - _id field not used, since OAG generates generates getId getter for both _id and id fields. - In JacksonMapper, turned off failing on unknown fields.
…st switched from PlayerSummary to GetSummaryResponse. SpringBoot module will fail.
…esponse. PlayerSummary deleted.
…dpoints into @nested subclasses. Test method names simplified accordingly.
…a brand-new user.
…PlayerEntity. - Added a spring-boot-starter-validation dependency to not fail SpringBoot on generated classes with javax.validation. - Added helper enum classes for new vocabulary fields. - Removed JsonObject usage from Dictionary to not fail the kgparserSpringBoot build on kefirSrv dependency.
…s caught by PlayerJsonParserTest and changed to logger.warn.
…esponse to PlayerJsonData. - Validation is not yet tested on new users database.
- Test-case for ugly player 24646 with numRaces: 1, avg_speed: null, avg_error: null added.
- Test-case for ugly player 80523 with voc-107263 with type: "" added.
- Test-case for ugly player 215941 with numRaces: 1, avg_speed: null, avg_error: null, best_speed: null added.
…ries. - Test-case for player 486990 with voc-186079 with symbols: -56 added.
…ryStatsEntity and saving them to the database. - Batch of 100 set to speed up the inserts.
…cabularyStatsEntity. Not the nicest code, but it is working!
…he selection from the database).
… the error page to old bucket.
Смёрджу текущую версию, так как тут сделаны изменения для переезда на http://klavostat.com. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.