-
-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli): Api health probe #645
base: develop
Are you sure you want to change the base?
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You missed adding canMakeHttpRequests
to these files:
- search.workspace.ts
- update.workspace.ts
They are also included in this PR |
544e34f
to
7919079
Compare
Oh, almost forgot, could you also include this in |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #645 +/- ##
===========================================
+ Coverage 91.71% 96.20% +4.48%
===========================================
Files 111 14 -97
Lines 2510 316 -2194
Branches 469 6 -463
===========================================
- Hits 2302 304 -1998
+ Misses 208 12 -196
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
User description
Description
For commands invoking API endpoints, the CLI first checks if the backend is reachable before executing the command itself by invoking the
/api/health
endpoint in order to give an accurate error message to the user about the issue.Fixes #601
Screenshots of relevant screens
Developer's checklist
If changes are made in the code:
Documentation Update
PR Type
Enhancement, Bug fix
Description
Added API health check in
BaseCommand
to validate backend connectivity.Implemented
canMakeHttpRequests
method in all command classes to enable HTTP checks.Introduced
AppController
for handling/api/health
endpoint requests.Updated
ControllerInstance
to initialize and manageAppController
.Changes walkthrough 📝
44 files
Added API health check in BaseCommand.
Added canMakeHttpRequests override for environment creation.
Added canMakeHttpRequests override for environment deletion.
Added canMakeHttpRequests override for fetching environment details.
Added canMakeHttpRequests override for listing environments.
Added canMakeHttpRequests override for updating environment details.
Added canMakeHttpRequests override for project creation.
Added canMakeHttpRequests override for project deletion.
Added canMakeHttpRequests override for project forking.
Added canMakeHttpRequests override for fetching project details.
Added canMakeHttpRequests override for listing project forks.
Added canMakeHttpRequests override for listing projects.
Added canMakeHttpRequests override for syncing projects.
Added canMakeHttpRequests override for unlinking projects.
Added canMakeHttpRequests override for updating project details.
Added canMakeHttpRequests override for secret creation.
Added canMakeHttpRequests override for secret deletion.
Added canMakeHttpRequests override for fetching secret details.
Added canMakeHttpRequests override for listing secrets.
Added canMakeHttpRequests override for fetching secret revisions.
Added canMakeHttpRequests override for rolling back secrets.
Added canMakeHttpRequests override for updating secret details.
Added canMakeHttpRequests override for variable creation.
Added canMakeHttpRequests override for variable deletion.
Added canMakeHttpRequests override for listing variables.
Added canMakeHttpRequests override for fetching variable revisions.
Added canMakeHttpRequests override for rolling back variables.
Added canMakeHttpRequests override for updating variable details.
Added canMakeHttpRequests override for workspace creation.
Added canMakeHttpRequests override for workspace deletion.
Added canMakeHttpRequests override for exporting workspaces.
Added canMakeHttpRequests override for fetching workspace details.
Added canMakeHttpRequests override for listing workspaces.
Added canMakeHttpRequests override for fetching workspace members.
Added canMakeHttpRequests override for workspace role creation.
Added canMakeHttpRequests override for workspace role deletion.
Added canMakeHttpRequests override for fetching workspace role
details.
Added canMakeHttpRequests override for listing workspace roles.
Added canMakeHttpRequests override for updating workspace roles.
Added canMakeHttpRequests override for searching workspaces.
Added canMakeHttpRequests override for updating workspace details.
Added AppController initialization in ControllerInstance.
Implemented AppController for API health checks.
Exported AppController from API client package.