feature: add network metrics + test #26
Conversation
Codecov Report
@@ Coverage Diff @@
## master #26 +/- ##
==========================================
+ Coverage 69.36% 70.92% +1.55%
==========================================
Files 27 28 +1
Lines 852 932 +80
Branches 193 210 +17
==========================================
+ Hits 591 661 +70
- Misses 199 201 +2
- Partials 62 70 +8
Continue to review full report at Codecov.
|
| debug('NetworkMetric destroyed !') | ||
| } | ||
|
|
||
| catchPorts () { |
There was a problem hiding this comment.
If i remember we decided to drop this metrics since not really useful.
There was a problem hiding this comment.
I add some configuration, so it's disable by default.
src/metrics/network.ts
Outdated
| value : function () { return up } | ||
| }) | ||
|
|
||
| const originalWrite = netModule.Socket.prototype.write |
There was a problem hiding this comment.
Is it possible to see why this patching break the AMQP clients ? keymetrics/pmx#52
Would be great if we can fix it
There was a problem hiding this comment.
The problem seems to be from amqp lib.
If I remove the line
this.on('data')
then the amqp server is responding, else we got a ECONNRESET error.
I add a configuration system to disable only the upload feature if necessary.
No description provided.