Make the API configuration modular #861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansasaki
force-pushed
the
modular_api_config
branch
from
2f506b4 to
5deb1f9
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ansasaki
force-pushed
the
modular_api_config
branch
from
5deb1f9 to
31f51c6
Compare
ansasaki
force-pushed
the
modular_api_config
branch
from
31f51c6 to
7f5d918
Compare
THS-on
reviewed
Nov 1, 2024
Move the /keys scope configuration from main to the keys_handler module. This is a preparation to support multiple API versions. Also, make the methods that are not required outside of the module private. Signed-off-by: Anderson Toshiyuki Sasaki <[email protected]>
Move the /quotes scope configuration from main to quotes_handler module. This is a preparation to support multiple API versions. Also, make the methods that are not required outside the module private. Signed-off-by: Anderson Toshiyuki Sasaki <[email protected]>
Move the /notifications scope configuration from main to notifications_handler. This is a preparation to support multiple API versions. Also, restrict the visibility of methods that are not required outside the module to private. Signed-off-by: Anderson Toshiyuki Sasaki <[email protected]>
Move the /agent scope configuration from main to agent_handler. This is a preparation to support multiple API versions. Also, restrict the visibility of methods that are not required outside the module to private. Signed-off-by: Anderson Toshiyuki Sasaki <[email protected]>
Move the API configuration to a dedicated file and make it modular. The API configuration is separated for each supported version. Currently only the latest API version (v2.2) is supported. This is a preparation to support multiple API versions. Signed-off-by: Anderson Toshiyuki Sasaki <[email protected]>
ansasaki
force-pushed
the
modular_api_config
branch
from
7f5d918 to
9e528f1
Compare
|
/packit retest-failed |
|
@ashcrow @mpeters @ueno @sergio-correia @aplanas Could someone please review/approve this? This PR is sitting for a month waiting for approval. We definitely need more Rust developers involved. |
sergio-correia
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the configuration of the API for each scope into the respective handler file.
Also, move the API configuration into a dedicated file, and make it modular.
This is a preparation to add support for multiple API versions.