Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tpm: check if EK certificate has valid ASN.1 DER encoding #845

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

THS-on
Copy link
Member

@THS-on THS-on commented Sep 25, 2024

Further this removes padding found on some TPMs in the NV indices.
If this is not valid, we still use it, but output a warning.

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.

Project coverage is 61.92%. Comparing base (2f7b3ad) to head (c92b617).
Report is 52 commits behind head on master.

Files with missing lines Patch % Lines
keylime/src/tpm.rs 77.77% 2 Missing ⚠️
Additional details and impacted files
Flag Coverage Δ
e2e-testsuite 61.92% <77.77%> (+4.33%) ⬆️
upstream-unit-tests 61.92% <77.77%> (+10.91%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
keylime/src/tpm.rs 71.55% <77.77%> (+5.37%) ⬆️

... and 9 files with indirect coverage changes

keylime/src/tpm.rs Outdated Show resolved Hide resolved
Further this removes padding found on some TPMs in the NV indices.
If this is not valid, we still use it, but output a warning.

Signed-off-by: Thore Sommer <[email protected]>
@ansasaki ansasaki merged commit 50dbd3f into keylime:master Oct 14, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants