Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Rubygem release engine #889

Closed
wants to merge 3 commits into from
Closed

feat: Rubygem release engine #889

wants to merge 3 commits into from

Conversation

mehulmathur16
Copy link
Contributor

/closes #491
/claim #491

@algora-pbc algora-pbc bot mentioned this pull request Sep 14, 2024
Closed
@mehulmathur16 mehulmathur16 changed the title feat: Rubygem engine feat: Rubygem release engine Sep 14, 2024
ezekg
ezekg requested changes Sep 14, 2024
View reviewed changes
app/controllers/api/v1/release_engines/rubygems/simple_controller.rb
render json: {
url: vanity_v1_account_release_artifact_url(artifact.account, artifact, filename: artifact.filename),
version: release.version,
pub_date: release.created_at.rfc3339(3),
Copy link
Member

@ezekg ezekg Sep 14, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the required format for Tauri —not Rubygems. This does not follow what Rubygems expects, i.e. this won't be installable via gem install foo --source https://rubygems.pkg.keygen.sh/bar.

@ezekg
Copy link
Member

ezekg commented Sep 14, 2024 •
edited
Loading

This isn't really what the request in #491 is describing. Are you sure you understand what's required?

@mehulmathur16
Copy link
Contributor Author

@ezekg I'll review the details in issue #491 again to ensure I'm fully aligned with the requirements.

@mehulmathur16 mehulmathur16 marked this pull request as draft September 14, 2024 22:54
@ezekg
Copy link
Member

ezekg commented Sep 15, 2024 •
edited
Loading

@mehulmathur16 there's implementations like Gitea's, GitLab's, and Rubygems.org's to study for a general idea of what I'm thinking here. In the end, I want a user to be able to upload a .gem file via the normal distribution API we already have, and essentially automate all of the manual work in this blog post — ultimately allowing a user to gem install the package like a normal gem from https://rubygems.org.

@ezekg
Copy link
Member

ezekg commented Sep 29, 2024

Closing due to inactivity. Feel free to open a new PR if you pick this up again. 👍

@ezekg ezekg closed this Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ezekg ezekg ezekg requested changes

Assignees
No one assigned
Labels
🙋 Bounty claim
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a release engine for Rubygems
2 participants
@mehulmathur16 @ezekg