Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extend the prometheus queries to both clusters #919

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

kami619
Copy link
Contributor

@kami619 kami619 commented Aug 8, 2024

fixes #914

  • Enables metrics gathering from both clusters for CPU Util of Logins, Credential grants, and Memory stats.

Working run: https://github.com/kami619/keycloak-benchmark/actions/runs/10355460317/job/28663154007
Working result JSON: https://github.com/kami619/keycloak-benchmark/blob/result-data/rosa_scalability/2024/08/12/result-20240812-161728-54455ba4-0cfb-4388-ac58-4031874c65f0.json

I created a follow-up task to clean up the way we are running Prometheus queries and performing the calculations, including repeating the login steps multiple times to fetch the THANOS host values and OC tokens.

@kami619 kami619 changed the title Is 914 metrics active active extend the prometheus queries to both clusters Aug 8, 2024
@kami619 kami619 force-pushed the is-914-metrics-active-active branch 5 times, most recently from e877294 to acad030 Compare August 12, 2024 16:09
@kami619 kami619 force-pushed the is-914-metrics-active-active branch from acad030 to ab717e8 Compare August 12, 2024 16:34
@kami619 kami619 marked this pull request as ready for review August 12, 2024 16:44
Copy link
Contributor

@ahus1 ahus1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look valid, though the numbers for the logins per vCPU are higher than I would expect.

Let's merge it and re-assess tomorrows regular run.

@ahus1 ahus1 merged commit 7eb95a4 into keycloak:main Aug 14, 2024
2 checks passed
@kami619 kami619 deleted the is-914-metrics-active-active branch August 14, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Aggregate the metrics across two clusters in A/A scheduled runs
2 participants