Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to ARM worker node types #1025

Merged
merged 1 commit into from
Nov 2, 2024
Merged

Conversation

kami619
Copy link
Contributor

@kami619 kami619 commented Oct 31, 2024

Fixes #1022

@ahus1
Copy link
Contributor

ahus1 commented Nov 1, 2024

Thank you - I think it will be green when you roll back the changes in provision/minikube/keycloak/templates/keycloak.yaml, the build will be green. Still, we might want those changes to be able to test in a mixed cluster, so then they would need to be conditional on an architecture selector.

@mhajas
Copy link
Contributor

mhajas commented Nov 1, 2024

We can use this in keycloak.yaml

{{ if eq .Values.environment "openshift" }}

Signed-off-by: Kamesh Akella <[email protected]>
@ahus1
Copy link
Contributor

ahus1 commented Nov 1, 2024

Hm, with the change {{ if eq .Values.environment "openshift" }} we now enforce ARM on OpenShift all the time. We would need to do this only on mixed clusters, as arm would be the default anyway in a pure ARM cluster. I'll comment in the parent issue about what is in scope and what not.

Copy link
Contributor

@mhajas mhajas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am merging this so we have the results on Monday

@mhajas mhajas merged commit a75da4e into keycloak:main Nov 2, 2024
4 checks passed
@kami619 kami619 deleted the is-1022-try-arm-out branch November 21, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support ARM based Keycloak deployments on ROSA
3 participants