convert report descriptors to TinyUSB macros #1385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Import class/hid/hid.h from the TinyUSB included in release 1.6 of the Adafruit nRF52 core. At least initially, these macros will be used to make HID report descriptors a bit easier to read and maintain. Signed-off-by: Taylor Yu <[email protected]>
Disable some TInyUSB definitions that we don't use (yet) and/or conflict with existing definitions in KeyboardioHID. Also import some other TinyUSB support macros, with minor fixes. The negative number issue with 16-bit report items is now hathach/tinyusb#2425 Signed-off-by: Taylor Yu <[email protected]>
Signed-off-by: Taylor Yu <[email protected]>
Signed-off-by: Taylor Yu <[email protected]>
Signed-off-by: Taylor Yu <[email protected]>
Signed-off-by: Taylor Yu <[email protected]>
Signed-off-by: Taylor Yu <[email protected]>
Signed-off-by: Taylor Yu <[email protected]>
Save a few bytes by removing a few redundant global settings from the Mouse report descriptor. Signed-off-by: Taylor Yu <[email protected]>
obra
reviewed
Jan 24, 2024
|
There were conflicts with some KeyboardioHID definitions, so I disabled as much stuff as possible that wasn't directly needed by the report descriptor work. I didn't take detailed notes of what all the conflicts were. I expect that I'll re-enable some of those definitions later, as I continue to improve abstractions and move away from the existing KeyboardioHID code. |
Delete a minimal set of conflicting definitions from KeyboardioHID, and make a few small adjustments to get things to compile. Signed-off-by: Taylor Yu <[email protected]>
|
It's not especially clean, but the most recent commit has most of |
Signed-off-by: Taylor Yu <[email protected]>
Don't use negative numbers in descriptors, because unmodified TinyUSB doesn't currently handle them, and even the single-byte ones trigger some warnings on nRF52, which has stricter warnings. Signed-off-by: Taylor Yu <[email protected]>
Signed-off-by: Taylor Yu <[email protected]>
|
Thanks so much for this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of a project to abstract the HID interface code away from particular device back end drivers, import a limited subset of the TinyUSB headers, and use their much nicer report descriptor macros to convert the existing KeyboardioHID report descriptors.
Other than a separate commit that slightly optimizes the Mouse descriptor, the resulting descriptors are byte-wise identical to the originals.