Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Macros: Rebuild with a completely different architecture #1094

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Macros: Rebuild with a completely different architecture #1094

wants to merge 1 commit into from

Commits on Dec 2, 2021

  1. Macros: Make it possible to read macros from sources other than PROGMEM 

    Instead of the `Macros` plugin reading from progmem unconditionally, allow one
to override a function (similar to how we can override `Layer.getKey()`), and
use that function to read macro data.

This allows `DynamicMacros` to re-use most of `Macros`, and not reimplement all
of it. The only remaining duplication is `updateDynamicMacroCache()`, which
walks the storage to build a macro index->offset map, and as such, needs to be
able to parse macros.

Signed-off-by: Gergely Nagy <[email protected]>
    @algernon
    algernon committed Dec 2, 2021
    Configuration menu
    Copy the full SHA
    46038df View commit details
    Browse the repository at this point in the history