Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change ${LCIO_LIBRARIES} to LCIO::lcio #290

Closed
wants to merge 1 commit into from
Closed

Change ${LCIO_LIBRARIES} to LCIO::lcio #290

wants to merge 1 commit into from

Conversation

jmcarcell
Copy link
Member

@jmcarcell jmcarcell commented Sep 17, 2023

BEGINRELEASENOTES

  • Change ${LCIO_LIBRARIES} to LCIO::lcio in CMakeLists.txt for cases when LCIO_LIBRARIES is empty. Also prevents linking to SIO when it's not necessary but it's included in LCIO_LIBRARIES

ENDRELEASENOTES

This is the same as iLCSoft/LCCD#7

@tmadlener
Copy link
Contributor

I am not entirely sure how $LCIO_LIBRARIES would be empty, and if it is whether we should not fix it upstream in LCIO instead of introducing workarounds in several downstream repositories.

@jmcarcell
Copy link
Member Author

jmcarcell commented Sep 18, 2023

PR updated, now works with iLCSoft/LCIO#177

I am not entirely sure how $LCIO_LIBRARIES would be empty, and if it is whether we should not fix it upstream in LCIO instead of introducing workarounds in several downstream repositories.

If you build together (at the same time) LCIO with another package then LCIO_LIBRARIES won't be set; one could set LCIO_LIBRARIES manually for this case to lcio and it will work. In this case where it's a single library that doesn't change over time we can use the target and have all build workflows working.

@jmcarcell jmcarcell changed the title Change ${LCIO_LIBRARIES} to lcio Change ${LCIO_LIBRARIES} to LCIO::lcio Sep 18, 2023
@andresailer
Copy link
Contributor

Superseded by #298

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants