Fix module resolution in typescript #736
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I've found another small issue when using typescript with this package. When using the tsconfig options
module: "NodeNext"
andmoduleResolution: "NodeNext"
, tsc showed the following error:This was fixed by b3821e0.
Also I noticed that when using typescript and go to definition VSCode would go to the
.d.ts
files instead of the js sources. This was fixed by adding the declarationmaps to the package which allow VSCode or another language server to connect the declarations and the source js files. 9401238.