[Feature] vCard phone-number escaping #517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kewisch
requested changes
Aug 17, 2022
lib/ical/design.js
Outdated
| }, | ||
| "phone-number":{ | ||
| fromICAL: function(aValue) { | ||
| return fmap(Array.from(aValue), c => c==='\\' ? undefined : c ).join(''); |
There was a problem hiding this comment.
Can you run the linters? I suspect this might fail due to missing spaces around operators.
As a bonus I'd also appreciate some performance testing to see if the conversion to and from an array is faster or slower than using indexOf and friends. I seem to recall there were some perf issues with large data sets in the past on this.
kewisch
approved these changes
Aug 18, 2022
kewisch
requested changes
Aug 18, 2022
kewisch
approved these changes
Aug 18, 2022
workgroupengineering
force-pushed
the
features/phone-number_escaping
branch
from
f1b2139 to
d6b2c41
Compare
kewisch
force-pushed
the
features/phone-number_escaping
branch
from
d6b2c41 to
9115c5d
Compare
kewisch
requested changes
Oct 15, 2022
There was a problem hiding this comment.
I adapted the changes on top of th es6 patches, either I did something wrong or there is a bug. @workgroupengineering can you double check?
workgroupengineering
force-pushed
the
features/phone-number_escaping
branch
from
9115c5d to
95735e5
Compare
I tried it on my machine it seems to work. |
Pull Request Test Coverage Report for Build 3264037023
💛 - Coveralls |
Pull Request Test Coverage Report for Build 3264037023
💛 - Coveralls |
kewisch
approved these changes
Oct 18, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rfc https://datatracker.ietf.org/doc/html/rfc6350#section-3.4
fixes nextcloud/contacts#1855
fixes nextcloud/contacts#1297