Fix Stringification for Parameters with Multiple Values #460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orced quoting ({multiValueSeparateDQuote: true})
kewisch
requested changes
Jul 13, 2021
Comment on lines
+121
to
126
| value = value.map(stringify._rfc6868Unescape); | ||
| if (designSet.param[paramName].multiValueSeparateDQuote) { | ||
| multiValue = '"' + multiValue + '"'; | ||
| value = value.map(function(v) { return '"' + v + '"'; }); | ||
| } | ||
| value = value.map(stringify._rfc6868Unescape); | ||
| value = value.map(stringify.propertyValue); | ||
| value = stringify.multiValue(value, multiValue, "unknown", null, designSet); |
There was a problem hiding this comment.
We are iterating value with map up to three times here, I think it might make sense to reduce this to one iteration.
| @@ -222,9 +224,13 @@ ICAL.stringify = (function() { | |||
| (helpers.unescapedIndexOf(value, ';') === -1)) { | |||
|
|
|||
| return value; | |||
| } | |||
| } else if (value.startsWith('"') && | |||
There was a problem hiding this comment.
Atfer return there is no need for else (in any language).
|
#555 is a different approach to the same problem. |
|
It looks like we haven't heard back on this issue, therefore we are closing this issue. If this problem persists in the latest version of ical.js, please re-open this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am currently trying to solve a problem when synchronizing contacts between nextcloud and macOS Contacts. One part of the problem seems to be that parameters with multiple values are not serialized correctly by ICAL.stringify. A phone number with multiple types (e.g. "HOME" and "VOICE") is serialized as TEL;TYPE="HOME,VOICE:0815 1234", which seems to be wrong according to the specification (https://tools.ietf.org/html/rfc2426#section-4 -> param = param-name "=" param-value *("," param-value)). The correct serialization should be TEL;TYPE=HOME,VOICE:0815 1234 or TEL;TYPE="HOME","VOICE":0815 1234.
My changes slightly update the serialization process for exactly this type of parameters. I have also added some tests to illustrate my changes.
Another possibility to fix my problem at hand would be to update the parameter configuration for phone numbers in design.js but I think that my solution which addresses the underlying problem is more general and hopefully future-proof.
Please let me know if my fix has any flaws or needs some further discussion!