-
Notifications
You must be signed in to change notification settings - Fork 61
Latest pytest (7.2.0) breaks pytest-parallel. #118
Comments
See pytest-dev/pytest#10420 (comment) for a similar issue. If pytest-parallel needs things in pylib outside of |
got it, thx |
@huntzhan Huh? This is a bug in pytest-parallel, so this shouldn't be closed until it's fixed here. |
Oh, I thought there's another issue to track the similar issue. Reopen again. |
Note the immediate fix for this is for In the long run, however, pytest-parallel should stop depending on pylib entirely, since we (pytest/pylib maintainers) want to sunset it. It's only used for logging. I'm not too familiar with |
@The-Compiler Thanks for your instruction! |
Co-authored-by: Jake Fennick <[email protected]>
Please see #119 (comment) Unfortunately, I recommend version pinning to pytest 7.1.3 while planning a move to pytest-xdist |
No need to pin, just add |
From this link [1] it looks like installing 'py' will solve the issue. Link: kevlened/pytest-parallel#118 Signed-off-by: Anders Roxell <[email protected]>
From this link [1] it looks like installing 'py' will solve the issue. Link: kevlened/pytest-parallel#118 Signed-off-by: Anders Roxell <[email protected]>
Got a warning in pytest-parallel, found out it's no longer maintained. kevlened/pytest-parallel#118
Sample output: platform linux -- Python 3.10.9, pytest-7.2.1, pluggy-1.0.0 rootdir: /home/ilyazub/Workspace/google-search-results-python plugins: parallel-0.1.1 collected 48 pytest-parallel: 8 workers (processes), 6 tests per worker (threads) `py` dependency is used because pytest-parallel depends on it but doesn't require 😕 kevlened/pytest-parallel#118 Co-authored-by: Dimitry <[email protected]>
To deal with this: https://github.com/openopt/copt/actions/runs/4490966091/jobs/7898766470#step:7:26 We follow this advice: kevlened/pytest-parallel#118 (comment)
…client (#30) * Use pagination parameters from SerpApi instead of calculating on the client `start` and `num` parameters are not suitable for token-based pagination. Such pagination is used on Google Maps, YouTube, Google Scholar Authors, and other search engines. This commit consumes URL query parameters for the next page. It stops paginating when parameters not change. Details: #22 Some tests are failing because `start` and `num` parameters are not supported anymore. These tests will be fixed in the following commits. * Add pagination tests for Bing, Baidu, and DuckDuckGo search API clients * Fix typo in SerpApi name in documentation * Add more pagination tests All of the tests follow the same pattern. Limit number of pages, iterate, and check for duplicates in the results. This is to make sure that pagination actually changes pages. * Test pagination for Naver and HomeDepot * Stop pagination when SerpApi backend doesn't update parameters * Fix flake8 linting errors Example errors: https://github.com/serpapi/google-search-results-python/runs/6659757610?check_suite_focus=true#step:5:37 * Lint code via `make lint` Currently linting script exists only in GitHub Action: `.github/workflows/python-package.yml`. This commit wraps that script in Makefile and invokes in an Action. * fix(tests): fix failing integration tests DuckDuckGo tests are failing because DuckDuckGo pagination doesn't take into account an offset of current results: serpapi/public-roadmap#619 Co-authored-by: Dimitry <[email protected]> * perf: run pytest in parallel Sample output: platform linux -- Python 3.10.9, pytest-7.2.1, pluggy-1.0.0 rootdir: /home/ilyazub/Workspace/google-search-results-python plugins: parallel-0.1.1 collected 48 pytest-parallel: 8 workers (processes), 6 tests per worker (threads) `py` dependency is used because pytest-parallel depends on it but doesn't require 😕 kevlened/pytest-parallel#118 Co-authored-by: Dimitry <[email protected]> * style: don't lint vendor packages with Flake8 Co-authored-by: Dimitry <[email protected]> * docs: fix minor typos in documentation Co-authored-by: Dimitry <[email protected]> * ci: cache pip dependencies Support Python 3.7+ based on the readme: https://github.com/serpapi/google-search-results-python/blob/35e51c94e7243c29650ed7b630db4e4e6d0c61aa/README.md#L18 Co-authored-by: "dimitryzub <[email protected]>" --------- Co-authored-by: Dimitry <[email protected]> Co-authored-by: Dimitry <[email protected]>
pytest just release a new version (7.1.3 -> 7.2.0) that breaks pytest-parallel. Error log:
INTERNALERROR> Traceback (most recent call last): INTERNALERROR> File "/opt/_internal/cpython-3.9.15/lib/python3.9/site-packages/_pytest/main.py", line 266, in wrap_session INTERNALERROR> config._do_configure() INTERNALERROR> File "/opt/_internal/cpython-3.9.15/lib/python3.9/site-packages/_pytest/config/__init__.py", line 1037, in _do_configure INTERNALERROR> self.hook.pytest_configure.call_historic(kwargs=dict(config=self)) INTERNALERROR> File "/opt/_internal/cpython-3.9.15/lib/python3.9/site-packages/pluggy/_hooks.py", line 277, in call_historic INTERNALERROR> res = self._hookexec(self.name, self.get_hookimpls(), kwargs, False) INTERNALERROR> File "/opt/_internal/cpython-3.9.15/lib/python3.9/site-packages/pluggy/_manager.py", line 80, in _hookexec INTERNALERROR> return self._inner_hookexec(hook_name, methods, kwargs, firstresult) INTERNALERROR> File "/opt/_internal/cpython-3.9.15/lib/python3.9/site-packages/pluggy/_callers.py", line 60, in _multicall INTERNALERROR> return outcome.get_result() INTERNALERROR> File "/opt/_internal/cpython-3.9.15/lib/python3.9/site-packages/pluggy/_result.py", line 60, in get_result INTERNALERROR> raise ex[1].with_traceback(ex[2]) INTERNALERROR> File "/opt/_internal/cpython-3.9.15/lib/python3.9/site-packages/pluggy/_callers.py", line 39, in _multicall INTERNALERROR> res = hook_impl.function(*args) INTERNALERROR> File "/opt/_internal/cpython-3.9.15/lib/python3.9/site-packages/pytest_parallel/__init__.py", line [11](https://github.com/vkit-x/vkit/actions/runs/3319272786/jobs/5484223267#step:8:12)1, in pytest_configure INTERNALERROR> config.pluginmanager.register(ParallelRunner(config), 'parallelrunner') INTERNALERROR> File "/opt/_internal/cpython-3.9.[15](https://github.com/vkit-x/vkit/actions/runs/3319272786/jobs/5484223267#step:8:16)/lib/python3.9/site-packages/pytest_parallel/__init__.py", line [19](https://github.com/vkit-x/vkit/actions/runs/3319272786/jobs/5484223267#step:8:20)6, in __init__ INTERNALERROR> self._log = py.log.Producer('pytest-parallel') INTERNALERROR> AttributeError: module 'py' has no attribute 'log'
The text was updated successfully, but these errors were encountered: