Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add wizard "template" #118

Merged
merged 7 commits into from
Oct 16, 2022
Merged

Add wizard "template" #118

merged 7 commits into from
Oct 16, 2022

Conversation

cavasinf
Copy link
Collaborator

Description

Add wizard telplate: https://preview.tabler.io/wizard.html

⚠️ Extends from fullpage template

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I updated the documentation (see here)
  • I agree that this code will be published under the MIT license

@cavasinf cavasinf added Status: Needs Review Not under investigation Feature Feature requested labels Sep 30, 2022
@cavasinf cavasinf added this to the 1.1 milestone Sep 30, 2022
kevinpapst
kevinpapst reviewed Oct 1, 2022
View reviewed changes
Copy link
Owner

@kevinpapst kevinpapst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason why all blocks are named wizzard and not wizard?

@cavasinf
Copy link
Collaborator Author

cavasinf commented Oct 1, 2022 via email

@cavasinf cavasinf added Status: Reviewed Has staff reply/investigation Status: Needs Work Need to be reworked and removed Status: Needs Review Not under investigation Status: Reviewed Has staff reply/investigation labels Oct 3, 2022
@cavasinf cavasinf self-assigned this Oct 3, 2022
@cavasinf cavasinf marked this pull request as draft October 3, 2022 09:43
@cavasinf cavasinf marked this pull request as ready for review October 3, 2022 10:25
@cavasinf cavasinf added Status: Reviewed Has staff reply/investigation and removed Status: Needs Work Need to be reworked labels Oct 3, 2022
@kevinpapst kevinpapst mentioned this pull request Oct 3, 2022
Merged
@cavasinf
Copy link
Collaborator Author

cavasinf commented Oct 4, 2022

As exposed in #120, blocks for card part here is called card_xxxx.
Do we keep that ?

kevinpapst
kevinpapst reviewed Oct 4, 2022
View reviewed changes
Copy link
Owner

@kevinpapst kevinpapst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two tiny things I'd like to mention:

  1. I tried to setup a demo of the wizard and would say that this template does not help that much. Shall we probably add some macros to render e.g. progress and button?
  2. The filename: shall we call it layout-wizard ?

@cavasinf
Copy link
Collaborator Author

cavasinf commented Oct 4, 2022

  1. Good idea, to replicate the Tabler demo page structure https://preview.tabler.io/wizard.html with two buttons bottom right + progress bar. TBH this is what I've done to my wizard template on my app 😉
  2. IDK.. In that case, what do we do with fullpage.html.twig ?

@kevinpapst kevinpapst modified the milestones: 1.1, 1.0 Oct 4, 2022
@kevinpapst
Copy link
Owner

  1. See, same in the demo. Do you want to do it before merging?
  2. Hm, missed that. Next bundle I start, I will think about naming before^^ then leave as is. The ones with layout- are the real layouts and the other ones and more like helper for special occasions.

cavasinf
cavasinf commented Oct 4, 2022
View reviewed changes
templates/wizard.html.twig Outdated Show resolved Hide resolved
kevinpapst
kevinpapst approved these changes Oct 16, 2022
View reviewed changes
Copy link
Owner

@kevinpapst kevinpapst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @cavasinf - if you feel like documentation 😁 please raise another PR.

@kevinpapst kevinpapst merged commit f9f99d3 into kevinpapst:main Oct 16, 2022
@cavasinf cavasinf deleted the feature/wizard branch October 17, 2022 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinpapst kevinpapst kevinpapst approved these changes

Assignees

@cavasinf cavasinf

Labels
Feature Feature requested Status: Reviewed Has staff reply/investigation
Projects
None yet
Milestone
1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@cavasinf @kevinpapst