Card embed block names

[cavasinf]

Big BC BREAK but we should rename blocks inside card embed.

TablerBundle/templates/embeds/card.html.twig

Line 24 in a2d91a6

<div class="card-header{% if block('box_header_class') is defined %} {{ block('box_header_class') }}{% endif %}">

They are called box_xxxxx as a remnant of AdminLTE. And classes card-xxxx
We should stick to Bootstrap and/or Tabler name convention and use card_xxxx instead.

WDYT ?

[kevinpapst]

Yeah, I think that is true: but I hate the idea, considering in how many files I use these block names ^^
But we should write a wrapper that is able to handle that name change for existing installations...

[cavasinf]

A "replace in files" CTRL + SHIFT + R from " box_" to " card_" (with a space at the beginning) should be enough? 😄

102+ ref on my side 😭

But we should write a wrapper that is able to handle that name change for existing installations...

And AdminLTEBundle Migration..

[kevinpapst]

Likely yes, but: my software supports plugins and there are many, which are not under my control... but they will have to adapt to the new theme anyway 😁 so good to go from my side.

[kevinpapst]

Changed the milestone, because this has to be done BEFORE the first "real" release.

[wucherpfennig]

Please just make sure to notify me before I update ;-) well... I will find out anyway ^^