fix: no need to create directory before creating a blob #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loicmathieu
force-pushed
the
fix/directory-creation-time
branch
2 times, most recently
from
6347813
to
7f671a7
Compare
loicmathieu
changed the title
loicmathieu
changed the title
loicmathieu
force-pushed
the
fix/directory-creation-time
branch
2 times, most recently
from
79ef99b
to
386fe21
Compare
loicmathieu
force-pushed
the
fix/directory-creation-time
branch
from
35ae1d0
to
7d13c9c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Directory creation is very slow in GCS and no necessary before creating a blob in a directory as directories are part of the name of a blob not a real filesystem structure.
Fixes #112
For the linked issue, times to split a file in 10 goes from 22s to less than 3s