Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Fix Pause property annotation, exclude Input subtypes from definitions #6265

Merged
merged 2 commits into from
Dec 4, 2024

Conversation

bppdanto-t
Copy link
Contributor

What changes are being made and why?


How the changes have been QAed?

  • Tested locally
    Documentation
    image

Form
image


Copy link
Member

@anna-geller anna-geller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like that filtering approach, big thanks for the PR! We can't merge today as we are in the release process so I'll add a reminder for tomorrow.

@Skraye feel free to add some tests if you feel this would be beneficial, otherwise I'll merge as is tomorrow 👍

@anna-geller
Copy link
Member

Yann explained that we cannot merge this PR as it would remove the autocompletion of onResume input types:

image

I'm very sorry @bppdanto-t - we won't be able to merge this one. Feel free to explore issues marked as good first issues available here

@anna-geller anna-geller closed this Dec 3, 2024
@Skraye Skraye reopened this Dec 4, 2024
@anna-geller anna-geller merged commit b9ccc4b into kestra-io:develop Dec 4, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Remove the long Inputs definitions from the Pause task documentation
3 participants