Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed the background behind the search input. #6220

Merged
merged 5 commits into from
Dec 4, 2024

Conversation

JoeCelaster
Copy link
Contributor

@JoeCelaster JoeCelaster commented Nov 30, 2024

What changes are being made and why?

  • Here I replaced the background-color into Background into None
  • Added a 1px solid border to .search.
  • For html.dark (dark theme): Background: Changed to transparent
  • Border Color: Set to a dark gray color (#404559)

How the changes have been QAed?

.search {
       display: flex;
       width: 22rem;
       padding: 0.25rem 2rem;
       justify-content: center;
       align-items: center;
       gap: 0.25rem;
       background: none;
       border: 1px solid var(--bs-gray-300);
   }

   html.dark .search {
       background: transparent; 
       border-color: #404559; 
   }

Closes #6180.

@MilosPaunovic MilosPaunovic self-requested a review December 1, 2024 14:35
@MilosPaunovic MilosPaunovic self-assigned this Dec 1, 2024
Copy link
Member

@MilosPaunovic MilosPaunovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've pushed a change that will amend the required issue, but you've guided me to the proper solution, so thanks for that @JoeCelaster! 🚀

Will be merged soon, after we got our release up and running.

@MilosPaunovic MilosPaunovic merged commit eb1cbfa into kestra-io:develop Dec 4, 2024
@MilosPaunovic
Copy link
Member

Just a small note for the future, if you could use GitHub Keywords when opening PRs to connect it to the proper issue (to automate the entire process a bit more), it would be super helpful to us. You can read a bit more about it here (I've added closing keyword for this particular issue).

MilosPaunovic added a commit that referenced this pull request Dec 4, 2024
@JoeCelaster
Copy link
Contributor Author

Firstly Thanks @MilosPaunovic for merging my pull request, and also thanks for the information i will follow this in future, Thank you !!.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Plugins page: Remove the background behind the search input.
2 participants