Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui):All popup windows now use markdown — some confirmation dialogs need adjustments #5986

Merged
merged 3 commits into from
Dec 4, 2024

Conversation

pphy03
Copy link
Contributor

@pphy03 pphy03 commented Nov 19, 2024

What changes are being made and why?


How the changes have been QAed?


Setup Instructions

Close #5981

@MilosPaunovic MilosPaunovic self-assigned this Nov 19, 2024
@Piyush-r-bhaskar
Copy link
Contributor

@MilosPaunovic May I ask for chance to review this at first step ?

@MilosPaunovic
Copy link
Member

MilosPaunovic commented Dec 3, 2024

Absolutely, that would be of great help, but this PR might be tricky as we want to go with a bit different approach, something like #5933.

May I suggest that, if you're willing to do PR reviews, try to check these ones: #6224, #6062, #6213? just bare in mind I would also have to review them before merging, it would not be anything related to your review being not alright or anything, it's just our process.

@Piyush-r-bhaskar
Copy link
Contributor

Absolutely, that would be of great help, but this PR might be tricky as we want to go with a bit different approach, something like #5933.

May I suggest that, if you're willing to do PR reviews, try to check these ones: #6224, #6062, #6213? just bare in mind I would also have to review them before merging, it would not be anything related to your review being not alright or anything, it's just our process.

Perfect...Thank You @MilosPaunovic

@Piyush-r-bhaskar
Copy link
Contributor

Just for your info. & to get suggestions: @MilosPaunovic @anna-geller

Note

If you see the JSON, the “force run confirm”: has content which includes <br>, <code>, <ul>, <li> tag for the work it does. But since the tags are being stripped, adding them in JSON won’t serve any purpose and as you can see from screenshot below, @pphy03 code has not entertained the tags as expected.

image
looks hard-coded
image

It should be something like this as per currently being used ElMessageBox

image
image

Tip

To implement something like below: ElDialog would be an option

image

Which is currently being used for Set Labels and Change State of Executions

image
image

Copy link
Member

@MilosPaunovic MilosPaunovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

You were on a good track here @pphy03, but I had to amend the approach a bit to align with some previous work on similar topic. Anyway, thanks a lot for the efforts here! 🚀

Thanks to you, as well @Piyush-r-bhaskar!

@MilosPaunovic MilosPaunovic merged commit 9cdaefc into kestra-io:develop Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

All popup windows now use markdown — some confirmation dialogs need adjustments
3 participants