-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
config: pipeline: Limit target trees/branches for Chromebook tests #962
config: pipeline: Limit target trees/branches for Chromebook tests #962
Conversation
e4e88c2
to
387e694
Compare
Baseline tests for Chromebooks may have different requirements regarding tree/branch combinations and other parameters compared to baseline tests on other platforms. To clarify this distinction, add a -chromebook suffix to the relevant test job definitions. Signed-off-by: Laura Nao <[email protected]>
Currently, most tests on Chromebooks run across all available tree/branch combinations. Restrict these tests to stable-rc and mainline trees to simplify monitoring while still identifying relevant regressions. Signed-off-by: Laura Nao <[email protected]>
@nuclearcat @pawiecz feel free to drop the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, let's drop skip-staging
and give it a test run before it can be deployed in prod
Thanks! I checked the results on staging - I see results on mainline/master, e.g.:
And I don't see results on the kernelci tree anymore, e.g.: So I guess this worked as expected. Now that I saw the results on staging, I wonder if we should keep running the tests on the kernelci tree as well though? otherwise they will just be available on the mainline tree on staging. Any thought on this @pawiecz @nuclearcat ? |
👍
Current default behavior on staging is to run tests from If you'd like to make Chromebook tests passing one of the Maestro PRs merge criteria then If you're confident about these test suites' stability and don't plan on changing them soon - filtering only mainline + stable-rc triggers should be fine (but it will require manual trigger on staging, if needed). |
Usually if something might affect non-kernelci tree tests i trigger that tree manually, so it is not necessary to add tests to kernelci tree. |
Ack, sounds good and should be ready to merge then. Thanks both for the feedback! |
Currently, most tests on Chromebooks run across all available tree/branch combinations. Restrict these tests to stable-rc and mainline trees to simplify monitoring while still identifying relevant regressions.