Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User management endpoint documentation #574

Merged
merged 2 commits into from
Nov 27, 2024

Conversation

JenySadadia
Copy link
Collaborator

Closes #521

Document user and user group endpoints.

@JenySadadia JenySadadia force-pushed the user-management-documentation branch from 02fbdb3 to 8a77e2b Compare November 26, 2024 10:28
@JenySadadia JenySadadia requested a review from pawiecz November 26, 2024 13:07
Copy link
Contributor

@pawiecz pawiecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

(my comments were intended to clarify endpoints usage but this should not block merging changes in docs)

This will return an authorization bearer token.


### Get all existing users
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this not an admin-only action? I believe this kind of information should have limited exposure

(this comment does not affect merging this patch but a new task to limit information access might be required)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This endpoint was initially admin only. But then requirements changed and we needed to make it public. I believe it was one of the requirements from @nuclearcat.

```


### Get user account matching user ID
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(see comment above)

### Update own user account

A user can update certain information for its own account, such as
`email`, `username`, `password`, and `groups` with a `PATCH /user/me` request.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

groups too? 😲

(this comment does not affect merging this patch but a new task to limit user access might be required)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the idea was that the user should be able to add and remove its user account to a group.
But yes, there has to be a concept of restricted groups which was in place when we used to have a specific user group for admin users (i.e. admin group). But then we eliminated the group and hence no restrictions are in place now.

@JenySadadia
Copy link
Collaborator Author

Created #578 based on @pawiecz's review comments.

@JenySadadia JenySadadia added this pull request to the merge queue Nov 27, 2024
Merged via the queue into kernelci:main with commit eebe581 Nov 27, 2024
6 checks passed
@JenySadadia JenySadadia deleted the user-management-documentation branch November 27, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document user management endpoints
2 participants