fix(requirements.txt): Add correct pymongo/motor dependencies #548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nuclearcat
force-pushed
the
fix-deps
branch
from
657ed64 to
ddda722
Compare
JenySadadia
reviewed
Sep 19, 2024
docker/api/requirements.txt
Outdated
| @@ -4,7 +4,8 @@ fastapi-pagination==0.9.3 | |||
| fastapi-users[beanie, oauth]==10.4.0 | |||
| fastapi-versioning==0.10.0 | |||
| MarkupSafe==2.0.1 | |||
| motor==3.3.2 | |||
| pymongo==4.9 | |||
There was a problem hiding this comment.
Suggested change
| pymongo==4.9 | |
| pymongo==4.9.0 |
JenySadadia
reviewed
Sep 19, 2024
pyproject.toml
Outdated
| "pymongo == 4.9.0", | ||
| "motor == 3.6.0", |
There was a problem hiding this comment.
Does it work if we keep packages in alphabetical order or do we need to pin pymongo first?
Suggested change
| "pymongo == 4.9.0", | |
| "motor == 3.6.0", | |
| "motor == 3.6.0", | |
| "pymongo == 4.9.0", |
There was a problem hiding this comment.
Yes, seems there is no requirements, so we can reorder it alphabetically
pymongo got updated and it was not fixed version in dependencies, as result it became incompatible with motor. Trying to fix versions to working ones. Signed-off-by: Denys Fedoryshchenko <[email protected]>
nuclearcat
force-pushed
the
fix-deps
branch
from
ddda722 to
8db1b62
Compare
JenySadadia
approved these changes
Sep 23, 2024
|
LGTM. Let's wait for staging results. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pymongo got updated and it was not fixed version in dependencies, as result it became incompatible with motor.
Trying to fix versions to working ones.