Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

api.user_manager: add username in log messages #408

Merged
merged 1 commit into from
Nov 16, 2023
Merged

api.user_manager: add username in log messages #408

merged 1 commit into from
Nov 16, 2023

Conversation

gctucker
Copy link
Contributor

Show the username in log messages in addition to the user ID. This makes it much easier to follow the logs when checking user activity.

JenySadadia
JenySadadia approved these changes Nov 15, 2023
View reviewed changes
Copy link
Collaborator

@JenySadadia JenySadadia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's wait for staging results.

@gctucker
api.user_manager: add username in log messages
461addf 
Show the username in log messages in addition to the user ID.  This
makes it much easier to follow the logs when checking user activity.

Signed-off-by: Guillaume Tucker <[email protected]>
@gctucker
Copy link
Contributor Author

Verified on staging:

$ zcat kernelci-api-2023-11-16T08-34-46.log.gz  | grep gtucker
2023-11-16T08:33:01.916156970Z INFO:     172.22.0.1:34924 - "GET /latest/users?username=gtucker&limit=100&offset=0 HTTP/1.0" 200 OK
2023-11-16T08:33:22.719968291Z Verification successful for user 62554673a68f9bac63a0ead2 gtucker
2023-11-16T08:33:34.285899307Z User 62554673a68f9bac63a0ead2 gtucker logged in.
2023-11-16T08:34:41.517971119Z User 62554673a68f9bac63a0ead2 gtucker has been updated.

@JenySadadia JenySadadia added this pull request to the merge queue Nov 16, 2023
Merged via the queue into kernelci:main with commit 8afe94f Nov 16, 2023
4 checks passed
@gctucker gctucker deleted the log-username branch November 16, 2023 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JenySadadia JenySadadia JenySadadia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gctucker @JenySadadia