Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add notes about Azure File share names #400

Merged
merged 1 commit into from
Nov 13, 2023

Conversation

gctucker
Copy link
Contributor

@gctucker gctucker commented Nov 9, 2023

The Azure File name might not be exactly the same as the username so add a note about that. Also add a related note about putting values in double quotes when they contain a dot so it gets parsed correctly in TOML with the dotted-key syntax.

@gctucker
Copy link
Contributor Author

Just noticed a typo in the commit message, it's a "note" and not a "node". Sending an update now.

@gctucker gctucker force-pushed the doc-azure-file-share-notes branch from d46d957 to 88e05f6 Compare November 10, 2023 07:59
@gctucker gctucker changed the title doc: add nodes about Azure File share names doc: add notes about Azure File share names Nov 10, 2023
@gctucker gctucker force-pushed the main branch 2 times, most recently from 97cb0df to 2ff0faf Compare November 10, 2023 12:48
The Azure File name might not be exactly the same as the username so
add a note about that.  Also add a related note about putting values
in double quotes when they contain a dot so it gets parsed correctly
in TOML with the dotted-key syntax.

Signed-off-by: Guillaume Tucker <[email protected]>
@gctucker gctucker force-pushed the doc-azure-file-share-notes branch from 88e05f6 to 33a622e Compare November 13, 2023 08:09
Copy link
Member

@nuclearcat nuclearcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@gctucker gctucker added this pull request to the merge queue Nov 13, 2023
Merged via the queue into kernelci:main with commit a1e7981 Nov 13, 2023
4 checks passed
@gctucker gctucker deleted the doc-azure-file-share-notes branch November 13, 2023 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants