Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api.db: add ne operator #368

Closed
wants to merge 0 commits into from

Conversation

JenySadadia
Copy link
Collaborator

Support ne(not equal to) operator while querying objects from API.
e.g. http://API_URL:8001/latest/nodes?name__ne=checkout will fetch all the nodes except ones with name checkout.

@nuclearcat
Copy link
Member

Isn't it already merged?
#357

@gctucker
Copy link
Contributor

gctucker commented Oct 3, 2023

Yes it's quite puzzling how GitHub can have a PR to change a line that's already changed in the same way 🤔

@gctucker
Copy link
Contributor

gctucker commented Oct 3, 2023

@JenySadadia Your branch was based on an older revision that didn't have @nuclearcat's changes. If you rebase then the changes in this PR disappear.

I would be interested to see how GitHub would manage that, like if we click on Merge now would it just mark it as "merged" without adding any actual commit to the branch? I don't really need to find out...

@JenySadadia
Copy link
Collaborator Author

This is weird.
Bdw looking at #357, I was the one who tested the PR and yet I created another one 😅

@JenySadadia
Copy link
Collaborator Author

It discarded my PR after rebase. The PR got closed automatically upon forced push.

@JenySadadia JenySadadia deleted the add-ne-operator branch October 3, 2023 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants